Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix high vulnerabilities #100

Closed
ClementVanPeuter opened this issue Jun 12, 2019 · 2 comments
Closed

Fix high vulnerabilities #100

ClementVanPeuter opened this issue Jun 12, 2019 · 2 comments
Assignees

Comments

@ClementVanPeuter
Copy link
Contributor

We have many high severity vulnerabilities.
I try to fix them with updates of the relevant packages.
The relevant packages are related to the Firebase solution, like firebase-admin and Firestore client.

But these upgrades introduced breaking change:
See here and here

@hgwood
Copy link
Member

hgwood commented Jun 12, 2019

Here's the list of breaking changes:

  • from upgrading from firebase-admin v6 to v7:

    • app must be compatible with Firestore client v1 (aka nodejs-firestore see below) ✅
  • from upgrading nodejs-firestore from v0 to v1

    • app must not expect Dates out of Firestore queries ✅ functions are globally configured to receive timestamps from queries (see here)
  • from upgrading from firebase-admin v7 to v8:

    • app must run on Node.js 8: ✅ we are already running on this version, as set in functions/package.json, see here and here
    • app must be compatible with Firestore client v2 (aka nodejs-firestore see below) ✅
  • from upgrading nodejs-firestore from v1 to v2

    • app must not use array arguments ✅ app does not call getAll or new FieldPath, see here for details of breaking change
    • app must not use getCollections

@hgwood
Copy link
Member

hgwood commented Jun 12, 2019

Conclusion: upgrading to firebase-admin v8 should be safe. See #99.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants