Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amendment: featureRemit #278

Merged
merged 53 commits into from Mar 10, 2024
Merged
Show file tree
Hide file tree
Changes from 21 commits
Commits
Show all changes
53 commits
Select commit Hold shift + click to select a range
8b11a10
Remit squashed (not compiling)
RichardAH Dec 28, 2023
1f14b40
change remit to use accountsend (more changes needed)
RichardAH Dec 28, 2023
3ca9f4d
Remit squashed
RichardAH Dec 28, 2023
d97d1c7
nit: log
dangell7 Jan 9, 2024
4ee8a9d
add: remit.h
dangell7 Jan 9, 2024
aee66c2
add test: preflight / doapply
dangell7 Jan 9, 2024
f23c118
Update tts.h
dangell7 Jan 9, 2024
2de6eb9
add ttREMIT to tsh
dangell7 Jan 9, 2024
12b3d9f
Merge branch 'release-testnet' into remit_clean
RichardAH Jan 9, 2024
1e5c896
add dest tag
dangell7 Jan 15, 2024
4babe0e
add remit tests
dangell7 Jan 15, 2024
6780978
Merge branch 'remit_clean' of github.com:Xahau/xahaud into remit_clean
dangell7 Jan 15, 2024
241e27e
dump
dangell7 Feb 1, 2024
b2217c1
Update Remit_test.cpp
dangell7 Feb 2, 2024
869a813
Merge branch 'dev' into remit_clean
dangell7 Feb 2, 2024
2bbf226
clang-format
dangell7 Feb 2, 2024
f609b32
Merge branch 'remit_clean' of github.com:Xahau/xahaud into remit_clean
dangell7 Feb 2, 2024
0c45613
fix bad merge
dangell7 Feb 2, 2024
c0e5763
update remit tsh
dangell7 Feb 6, 2024
5029ff0
add remit tsh test
dangell7 Feb 6, 2024
2c4152a
add remit tests
dangell7 Feb 6, 2024
410278c
add limit to amounts & uritokenids
dangell7 Feb 7, 2024
6b53f5b
update remit tsh
dangell7 Feb 7, 2024
6274d2f
clang-format
dangell7 Feb 7, 2024
18eced5
remove cross tsh
dangell7 Feb 7, 2024
a334a77
`asfAllowIncomingRemit`
dangell7 Feb 19, 2024
a277f77
Merge branch 'dev' into remit_clean
dangell7 Feb 19, 2024
264f700
add `lsfAllowIncoming` to AccountInfo
dangell7 Feb 19, 2024
0ec024e
Update SetHookTSH_test.cpp
dangell7 Feb 19, 2024
cb28b4f
clang-format
dangell7 Feb 19, 2024
0712a92
`lsfDisallowIncomingRemit`
dangell7 Feb 24, 2024
ab73ae0
cleanup `lsfDisallowIncomingRemit`
dangell7 Feb 24, 2024
ffdabc9
add `DepositAuth`
dangell7 Feb 24, 2024
5e5590b
clang-format
dangell7 Feb 24, 2024
2ca2073
Merge branch 'dev' into remit_clean
dangell7 Feb 24, 2024
4e8c0b4
remove `sfFlags` from `sfAmountEntry`
dangell7 Feb 29, 2024
2c381d4
address review comments
dangell7 Mar 4, 2024
0a7e637
Update Remit_test.cpp
dangell7 Mar 4, 2024
86d45ad
tx consequences, flags
dangell7 Mar 7, 2024
66aa311
clang
dangell7 Mar 7, 2024
f6023e1
add inform account guard
dangell7 Mar 7, 2024
b872d44
update tsh
dangell7 Mar 7, 2024
c8952d0
fixup
dangell7 Mar 7, 2024
1f852bd
add inform test
dangell7 Mar 7, 2024
384999b
fix test bad sequence
dangell7 Mar 7, 2024
8a73081
ensure sfInform is not the same as source or destination
RichardAH Mar 10, 2024
c5e086d
add extra sanity checks
RichardAH Mar 10, 2024
393d95b
fix sender pays fee for remit + clang
RichardAH Mar 10, 2024
713d81a
fix transfer rate tests
dangell7 Mar 10, 2024
40ef57b
clang-format
dangell7 Mar 10, 2024
e01d9ad
remove unnecessary check
dangell7 Mar 10, 2024
9b4b37a
nit
dangell7 Mar 10, 2024
4f12234
overflow checks
RichardAH Mar 10, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions Builds/CMake/RippledCore.cmake
Expand Up @@ -455,6 +455,7 @@ target_sources (rippled PRIVATE
src/ripple/app/tx/impl/GenesisMint.cpp
src/ripple/app/tx/impl/Import.cpp
src/ripple/app/tx/impl/Invoke.cpp
src/ripple/app/tx/impl/Remit.cpp
src/ripple/app/tx/impl/SetSignerList.cpp
src/ripple/app/tx/impl/SetTrust.cpp
src/ripple/app/tx/impl/SignerEntries.cpp
Expand Down Expand Up @@ -740,6 +741,7 @@ if (tests)
src/test/app/RCLCensorshipDetector_test.cpp
src/test/app/RCLValidations_test.cpp
src/test/app/Regression_test.cpp
src/test/app/Remit_test.cpp
src/test/app/SHAMapStore_test.cpp
src/test/app/SetAuth_test.cpp
src/test/app/SetRegularKey_test.cpp
Expand Down Expand Up @@ -889,6 +891,7 @@ if (tests)
src/test/jtx/impl/rate.cpp
src/test/jtx/impl/regkey.cpp
src/test/jtx/impl/reward.cpp
src/test/jtx/impl/remit.cpp
src/test/jtx/impl/sendmax.cpp
src/test/jtx/impl/seq.cpp
src/test/jtx/impl/sig.cpp
Expand Down
1 change: 1 addition & 0 deletions hook/tts.h
Expand Up @@ -31,6 +31,7 @@
#define ttURITOKEN_BUY 47
#define ttURITOKEN_CREATE_SELL_OFFER 48
#define ttURITOKEN_CANCEL_SELL_OFFER 49
#define ttREMIT 95
#define ttGENESIS_MINT 96
#define ttIMPORT 97
#define ttCLAIM_REWARD 98
Expand Down
11 changes: 11 additions & 0 deletions src/ripple/app/hook/impl/applyHook.cpp
Expand Up @@ -70,6 +70,17 @@ getTransactionalStakeHolders(STTx const& tx, ReadView const& rv)

switch (tt)
{

case ttREMIT: {
if (destAcc)
ADD_TSH(*destAcc, tshSTRONG);

if (tx.isFieldPresent(sfInform))
dangell7 marked this conversation as resolved.
Show resolved Hide resolved
ADD_TSH(tx.getAccountID(sfInform), tshWEAK);

break;
dangell7 marked this conversation as resolved.
Show resolved Hide resolved
}

case ttIMPORT: {
if (tx.isFieldPresent(sfIssuer))
ADD_TSH(tx.getAccountID(sfIssuer), fixV2 ? tshWEAK : tshSTRONG);
Expand Down
3 changes: 2 additions & 1 deletion src/ripple/app/tx/impl/InvariantCheck.cpp
Expand Up @@ -597,7 +597,8 @@ ValidNewAccountRoot::finalize(
return false;
}

if ((tt == ttPAYMENT || tt == ttIMPORT || tt == ttGENESIS_MINT) &&
if ((tt == ttPAYMENT || tt == ttIMPORT || tt == ttGENESIS_MINT ||
tt == ttREMIT) &&
result == tesSUCCESS)
{
std::uint32_t const startingSeq{
Expand Down