Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amendment: featureRemit #278

Merged
merged 53 commits into from Mar 10, 2024
Merged

Amendment: featureRemit #278

merged 53 commits into from Mar 10, 2024

Conversation

dangell7
Copy link
Collaborator

@dangell7 dangell7 commented Feb 2, 2024

High Level Overview of Change

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@dangell7 dangell7 added the Amendment New feature or fix amendment label Feb 2, 2024
@tequdev
Copy link
Contributor

tequdev commented Feb 3, 2024

Is it expected that the transaction will succeed if none of the fields sfAmounts, sfURITokenIDs, or sfMintURIToken are specified?

From the code it looks like it will succeed, but it may be appropriate that it will be an error.

It's okay if success is expected.

@dangell7
Copy link
Collaborator Author

dangell7 commented Feb 3, 2024

Is it expected that the transaction will succeed if none of the fields sfAmounts, sfURITokenIDs, or sfMintURIToken are specified?

From the code it looks like it will succeed, but it may be appropriate that it will be an error.

It's okay if success is expected.

It will create the account if the account does not exist.

@dangell7 dangell7 marked this pull request as draft February 3, 2024 09:28
src/ripple/app/tx/impl/Remit.cpp Outdated Show resolved Hide resolved
src/ripple/app/tx/impl/Remit.cpp Outdated Show resolved Hide resolved
src/ripple/app/tx/impl/Remit.cpp Outdated Show resolved Hide resolved
src/ripple/app/tx/impl/Remit.cpp Show resolved Hide resolved
src/ripple/app/tx/impl/Remit.cpp Outdated Show resolved Hide resolved
src/ripple/app/tx/impl/Remit.cpp Outdated Show resolved Hide resolved
src/ripple/app/tx/impl/Remit.cpp Outdated Show resolved Hide resolved
src/ripple/app/tx/impl/Remit.cpp Outdated Show resolved Hide resolved
src/ripple/app/tx/impl/Remit.cpp Show resolved Hide resolved
src/ripple/app/hook/impl/applyHook.cpp Show resolved Hide resolved
src/ripple/app/hook/impl/applyHook.cpp Outdated Show resolved Hide resolved
src/ripple/app/tx/impl/Remit.cpp Outdated Show resolved Hide resolved
src/ripple/app/tx/impl/Remit.cpp Outdated Show resolved Hide resolved
@RichardAH RichardAH merged commit 75aba53 into dev Mar 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Amendment New feature or fix amendment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants