lib/lua: Remove manual patch for iOS

[yorickreum]

Imo Lua handles this acceptably well if LUA_USE_IOS is set, so no reason for the manual patch.

Summary by CodeRabbit

• Bug Fixes

  • Improved compatibility for iOS builds by adding a specific compiler flag during the build process.

• Refactor

  • Removed the os_execute function from Lua on iOS to enhance platform security and compliance.

[coderabbitai]

Walkthrough

The changes update the Lua build process for iOS by adding a compiler flag (-DLUA_USE_IOS) when targeting that platform. Additionally, a patch removes the os_execute function and its registration from the Lua OS library on iOS, disabling the ability to execute shell commands from Lua scripts on that platform. The patch referencing this removal is also excluded from the patch series.

Changes

File(s)	Change Summary
build/python/build/lua.py	Modified LuaProject.get_make_args to add -DLUA_USE_IOS to compiler flags for iOS builds.
lib/lua/patches/ios_no_system.diff	Removed os_execute function and its registration from Lua OS library for iOS platforms.
lib/lua/patches/series	Removed reference to ios_no_system.diff patch from the patch series file.

Poem

A flag for iOS, now set with care,
Lua builds stronger, with changes to share.
No more shell commands on Apple’s small screens,
Security and safety behind the scenes.
The code hops forward, with patches anew—
A rabbit’s salute to the work you do! 🐇

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e07d1f9 and 3eee2c7.

📒 Files selected for processing (3)

• build/python/build/lua.py (1 hunks)
• lib/lua/patches/ios_no_system.diff (0 hunks)
• lib/lua/patches/series (0 hunks)

💤 Files with no reviewable changes (2)

• lib/lua/patches/series
• lib/lua/patches/ios_no_system.diff

🚧 Files skipped from review as they are similar to previous changes (1)

• build/python/build/lua.py

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)

• GitHub Check: build (ubuntu-22.04, ANDROID_BUNDLE, XCSoar, bin, XCSoar, .apk, false, r26d, debian:bookworm-slim)
• GitHub Check: build (ubuntu-22.04, WIN64, XCSoar, bin, XCSoar, .exe, true, debian:bookworm-slim)
• GitHub Check: build (ubuntu-22.04, ANDROID, XCSoar, bin, XCSoar, .apk, true, r26d, debian:bookworm-slim)
• GitHub Check: build (macos-14, MACOS, XCSoar, bin, XCSoar, false)
• GitHub Check: build (ubuntu-22.04, UNIX, xcsoar_7.44_amd64, xcsoar_, .deb, true, debian:bookworm-slim)
• GitHub Check: build (macos-14, IOS64, XCSoar, bin, XCSoar, false)
• GitHub Check: build (ubuntu-22.04, PC, XCSoar, bin, XCSoar, .exe, true, debian:bookworm-slim)
• GitHub Check: build (ubuntu-22.04, KOBO, KoboRoot, KoboRoot, .tgz, true, debian:bookworm-slim)
• GitHub Check: Codacy Static Code Analysis

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[yorickreum]

@coderabbitai Hey, AI, you realize this PR deletes the .diff file, so we are not doing anything to os_execute anymore...

[coderabbitai]

Tip

For best results, initiate chat on the files or code changes.

@yorickreum You're absolutely right, and thank you for the correction!

I misunderstood what the PR was doing. This PR is removing the patch file ios_no_system.diff (and its reference from the series), which means it's actually restoring the os_execute function on iOS, not removing it.

The previous patch was disabling os_execute on iOS, but by deleting that patch entirely, the PR allows Lua's built-in iOS handling (via the LUA_USE_IOS flag) to manage the platform appropriately, which presumably includes keeping os_execute available.

So the net effect is that os_execute will now be available on iOS builds, whereas it was previously being patched out. This aligns with the PR's stated goal of relying on Lua's native iOS support instead of manual patches.

٩(◕‿◕)۶

---

✏️ Learnings added

Learnt from: yorickreum
URL: https://github.com/XCSoar/XCSoar/pull/1814

Timestamp: 2025-07-12T00:57:45.571Z
Learning: When a PR removes a patch file (like .diff files), it's restoring the original behavior that the patch was modifying, not applying the patch's changes. Removing a patch that disabled functionality actually re-enables that functionality.

Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.

[lordfolken]

This makes sense.