Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(TorrentDetail): Use colors for ratio and chips #1662

Merged
merged 2 commits into from Apr 25, 2024

Conversation

Larsluph
Copy link
Collaborator

Apply colors on ratio and chips inside the torrent detail following the same rules as the dashboard components.

Also improved test environment by suppressing vue-router injection warnings and tweaking vitest configuration.

@Larsluph Larsluph self-assigned this Apr 24, 2024
@Larsluph Larsluph requested a review from WDaan as a code owner April 24, 2024 22:49
const value = 'foo'
const fooRgb = 'rgb(123, 47, 222)'

describe('ColoredChip.vue', () => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@Larsluph Larsluph merged commit c902d62 into master Apr 25, 2024
1 check passed
@Larsluph Larsluph deleted the perf/detail-colors branch April 25, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants