Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
perf(TorrentDetail): Use colors for ratio and chips (#1662)
- Loading branch information
Showing
11 changed files
with
160 additions
and
50 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| import i18n from '@/plugins/i18n' | ||
| import vuetify from '@/plugins/vuetify' | ||
| import { createTestingPinia } from '@pinia/testing' | ||
| import { mount } from '@vue/test-utils' | ||
| import { describe, expect, it } from 'vitest' | ||
| import ColoredChip from './ColoredChip.vue' | ||
|
|
||
| const defaultColor = 'default' | ||
| const disabledValue = 'disabled value' | ||
| const value = 'foo' | ||
| const fooRgb = 'rgb(123, 47, 222)' | ||
|
|
||
| describe('ColoredChip.vue', () => { | ||
| it('should render chip with random color and value', () => { | ||
| const chip = mount(ColoredChip, { | ||
| props: { defaultColor, value }, | ||
| global: { | ||
| plugins: [ | ||
| createTestingPinia({ | ||
| initialState: { | ||
| vuetorrent: { | ||
| enableHashColors: true | ||
| } | ||
| } | ||
| }), | ||
| i18n, | ||
| vuetify | ||
| ] | ||
| } | ||
| }) | ||
|
|
||
| expect(chip.attributes().style).toContain(`background-color: ${fooRgb}`) | ||
| expect(chip.text()).toBe(value) | ||
| }) | ||
|
|
||
| it('should render chip with default color and value', () => { | ||
| const chip = mount(ColoredChip, { | ||
| props: { defaultColor, value }, | ||
| global: { | ||
| plugins: [ | ||
| createTestingPinia({ | ||
| initialState: { | ||
| vuetorrent: { | ||
| enableHashColors: false | ||
| } | ||
| } | ||
| }), | ||
| i18n, | ||
| vuetify | ||
| ] | ||
| } | ||
| }) | ||
|
|
||
| expect(chip.classes()).toContain(`bg-${defaultColor}`) | ||
| expect(chip.text()).toBe(value) | ||
| }) | ||
|
|
||
| it('should render chip with default color and default value', () => { | ||
| const chip = mount(ColoredChip, { | ||
| props: { defaultColor, disabled: true, disabledValue, value }, | ||
| global: { | ||
| plugins: [ | ||
| createTestingPinia({ | ||
| initialState: { | ||
| vuetorrent: { | ||
| enableHashColors: true | ||
| } | ||
| } | ||
| }), | ||
| i18n, | ||
| vuetify | ||
| ] | ||
| } | ||
| }) | ||
|
|
||
| expect(chip.classes()).toContain(`bg-${defaultColor}`) | ||
| expect(chip.text()).toBe(disabledValue) | ||
| }) | ||
| }) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| <script setup lang="ts"> | ||
| import { storeToRefs } from 'pinia' | ||
| import { useVueTorrentStore } from '@/stores' | ||
| import { computed } from 'vue' | ||
| import { getColorFromName } from '@/helpers' | ||
| import { useI18n } from 'vue-i18n' | ||
| const props = withDefaults( | ||
| defineProps<{ | ||
| defaultColor: string | ||
| disabled?: boolean | ||
| disabledValue?: string | ||
| value: string | ||
| }>(), | ||
| { | ||
| disabled: false | ||
| } | ||
| ) | ||
| const { t } = useI18n() | ||
| const { enableHashColors } = storeToRefs(useVueTorrentStore()) | ||
| const chipColor = computed(() => (props.disabled || !enableHashColors.value ? props.defaultColor : getColorFromName(props.value))) | ||
| const chipValue = computed(() => (props.disabled ? props.disabledValue || t('common.none') : props.value)) | ||
| </script> | ||
|
|
||
| <template> | ||
| <v-chip :color="chipColor" variant="flat"> | ||
| {{ chipValue }} | ||
| </v-chip> | ||
| </template> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,19 @@ | ||
| import { expect, test } from 'vitest' | ||
| import { getColorFromName } from './colors' | ||
| import { getColorFromName, getRatioColor } from './colors' | ||
|
|
||
| test('helpers/colors/getColorFromName', () => { | ||
| expect(getColorFromName('foo')).toBe('#7b2fde') | ||
| expect(getColorFromName('bar')).toBe('#97e374') | ||
| expect(getColorFromName('baz')).toBe('#447ecf') | ||
| }) | ||
|
|
||
| test('helpers/colors/getRatioColor', () => { | ||
| expect(getRatioColor(0)).toBe('text-ratio-bad') | ||
| expect(getRatioColor(0.4)).toBe('text-ratio-bad') | ||
| expect(getRatioColor(0.5)).toBe('text-ratio-almost') | ||
| expect(getRatioColor(0.9)).toBe('text-ratio-almost') | ||
| expect(getRatioColor(1)).toBe('text-ratio-good') | ||
| expect(getRatioColor(4.9)).toBe('text-ratio-good') | ||
| expect(getRatioColor(5)).toBe('text-ratio-best') | ||
| expect(getRatioColor(10)).toBe('text-ratio-best') | ||
| }) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,3 @@ | ||
| import { vi } from 'vitest' | ||
|
|
||
| Object.defineProperty(window, 'matchMedia', { | ||
| writable: true, | ||
| value: vi.fn().mockImplementation(query => ({ | ||
| matches: false, | ||
| media: query, | ||
| onchange: null, | ||
| addListener: vi.fn(), // deprecated | ||
| removeListener: vi.fn(), // deprecated | ||
| addEventListener: vi.fn(), | ||
| removeEventListener: vi.fn(), | ||
| dispatchEvent: vi.fn() | ||
| })) | ||
| }) | ||
| vi.mock('vue-router') |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters