Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to ngrx v4 #378

Merged
merged 14 commits into from
Oct 8, 2017
Merged

Upgrade to ngrx v4 #378

merged 14 commits into from
Oct 8, 2017

Conversation

fjozsef
Copy link
Contributor

@fjozsef fjozsef commented Jul 30, 2017

ngrx to v4

@fjozsef fjozsef requested a review from ert78gb July 30, 2017 21:56
@mondalaci
Copy link
Member

Agent-electron fails for me:

untitled

@mondalaci mondalaci mentioned this pull request Jul 31, 2017
Closed
@fjozsef fjozsef force-pushed the update-dependencies branch 2 times, most recently from ef90d66 to 47b5cf2 Compare August 3, 2017 19:36
@fjozsef
Copy link
Contributor Author

fjozsef commented Aug 3, 2017

@ert78gb Could you help with the migration? it seems runAfterBootstrap has changed. We'd need to use https://github.com/ngrx/platform/blob/master/docs/effects/api.md#onruneffects

@ert78gb
Copy link
Member

ert78gb commented Aug 3, 2017

of course. Could you pending this issue for 1-3 day . I think I will finish the feature module development and after I could help.
I think better if refactor the store in new module system.
Is it ok for you?

@fjozsef
Copy link
Contributor Author

fjozsef commented Aug 3, 2017

Sure, thanks.

@fjozsef fjozsef changed the title Update dependencies Upgrade to ngrx v4 Aug 12, 2017
@fjozsef
Copy link
Contributor Author

fjozsef commented Aug 12, 2017

It is blocked until ngrx-store-freeze is incompatible with NgRx 4.

@mondalaci
Copy link
Member

Referencing the relevant issue: brandonroberts/ngrx-store-freeze#17

@mondalaci
Copy link
Member

According to the relevant NgRx issue, "Version 0.2.0 has been released with support for NgRx V4.x", so I'm removing the blocked tag.

@fjozsef Will you be able to wrap this up, or should @ert78gb finish it?

@mondalaci mondalaci removed the blocked label Oct 6, 2017
@fjozsef
Copy link
Contributor Author

fjozsef commented Oct 6, 2017

@mondalaci Unfortunatelly no, I don't think I will have time for it.

@mondalaci
Copy link
Member

@fjozsef No problem at all. Assigning this to @ert78gb then.

@mondalaci mondalaci added this to Robi in Agent todo Oct 6, 2017
@ert78gb ert78gb requested review from mondalaci and removed request for ert78gb October 7, 2017 17:53
@ert78gb ert78gb moved this from Robi to Under review in Agent todo Oct 7, 2017
@ert78gb
Copy link
Member

ert78gb commented Oct 7, 2017

this PR contains the solution of #406 issue.
close: #406

@ert78gb ert78gb mentioned this pull request Oct 7, 2017
Closed
@mondalaci
Copy link
Member

mondalaci commented Oct 7, 2017 •
edited

This doesn't look right:

untitled

I've cloned Agent and built it from the ground up, and I could reproduce the above empty state in both the electron and the web build.

@ert78gb
Copy link
Member

ert78gb commented Oct 8, 2017

I think I fix all bug

@mondalaci mondalaci merged commit 50e0b64 into master Oct 8, 2017
@mondalaci mondalaci deleted the update-dependencies branch October 8, 2017 16:31
@mondalaci mondalaci moved this from Under review to Done in Agent todo Oct 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mondalaci mondalaci Awaiting requested review from mondalaci

Assignees

@ert78gb ert78gb

Labels
None yet
Projects
Agent todo
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fjozsef @mondalaci @ert78gb