Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lock package-lock.json files #406

Closed
mondalaci opened this issue Sep 6, 2017 · 8 comments
Closed

Lock package-lock.json files #406

mondalaci opened this issue Sep 6, 2017 · 8 comments
Assignees
@ert78gb
Labels
blocked enhancement

Comments

@mondalaci
Copy link
Member

So that they won't keep changing, and it'll make sure that our build won't break due to changed external dependencies.
@mondalaci mondalaci added this to Robi in Agent todo Oct 7, 2017
@ert78gb ert78gb mentioned this issue Oct 7, 2017
Merged
@ert78gb ert78gb moved this from Robi to Under review in Agent todo Oct 7, 2017
@ert78gb
Copy link
Member

ert78gb commented Oct 7, 2017

Solved in #378

@mondalaci mondalaci moved this from Under review to Done in Agent todo Oct 8, 2017
@mondalaci mondalaci moved this from Done to Robi in Agent todo Oct 18, 2017
@ert78gb
Copy link
Member

ert78gb commented Oct 26, 2017 •
edited

related to: lerna/lerna#913, lerna/lerna#938

@ert78gb ert78gb mentioned this issue Oct 26, 2017
Merged
@mondalaci
Copy link
Member Author

Related issues:

@mondalaci mondalaci moved this from Robi to Under review in Agent todo Oct 28, 2017
@mondalaci mondalaci moved this from Under review to Done in Agent todo Oct 28, 2017
@mondalaci mondalaci removed this from Done in Agent todo Oct 28, 2017
@mondalaci
Copy link
Member Author

This cannot be fixed yet due to OS-specific packages. Let's revisit it later when resolved by npm or yarn.

@mondalaci
Copy link
Member Author

Looks like this has been resolved by the recent npm update.

@mondalaci mondalaci reopened this Dec 9, 2017
@mondalaci
Copy link
Member Author

Unfortunately, the issue regarding OS-specific packages still stands.

@ert78gb
Copy link
Member

ert78gb commented Dec 9, 2017

did you upgraded your npm to 5.6.0?

@mondalaci
Copy link
Member Author

I haven't encountered with this for a while, so I think that a recent npm upgrade solved this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ert78gb ert78gb

Labels
blocked enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mondalaci @ert78gb