Updated node-gyp to v8.x
#1566
Merged
Updated node-gyp to v8.x
#1566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs #1493 refs nodejs/node-gyp#2474 - `node-gyp` 7.x has a minimum `tar` version of 6.0.2, which has a security vulnerability listed against it - `node-gyp` 8.x updates the minimum to 6.1.2, which contains the fix - `node-gyp` 8.x should still allow us to use Node 10, so we're good with Node compatibility - it also seems to fix the `PYTHON` env variable being set, which helps fix the build for MacOS Monterey (coming in the next commit)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #1493
refs nodejs/node-gyp#2474
node-gyp7.x has a minimumtarversion of 6.0.2, which has asecurity vulnerability listed against it
node-gyp8.x updates the minimum to 6.1.2, which contains the fixnode-gyp8.x should still allow us to use Node 10, so we're goodwith Node compatibility
PYTHONenv variable being set, which helpsfix the build for MacOS Monterey (coming in the next commit)