Skip to content

Commit

Permalink
Updated node-gyp to v8.x
Browse files Browse the repository at this point in the history
refs #1493
refs nodejs/node-gyp#2474

- `node-gyp` 7.x has a minimum `tar` version of 6.0.2, which has a
  security vulnerability listed against it
- `node-gyp` 8.x updates the minimum to 6.1.2, which contains the fix
- `node-gyp` 8.x should still allow us to use Node 10, so we're good
  with Node compatibility
- it also seems to fix the `PYTHON` env variable being set, which helps
  fix the build for MacOS Monterey (coming in the next commit)
  • Loading branch information
daniellockyer committed Apr 12, 2022
1 parent 7c85933 commit 859b95b
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions package.json
Expand Up @@ -49,15 +49,15 @@
"mocha": "^9.2.2"
},
"peerDependencies": {
"node-gyp": "7.x"
"node-gyp": "8.x"
},
"peerDependenciesMeta": {
"node-gyp": {
"optional": true
}
},
"optionalDependencies": {
"node-gyp": "7.x"
"node-gyp": "8.x"
},
"scripts": {
"install": "node-pre-gyp install --fallback-to-build",
Expand Down

0 comments on commit 859b95b

Please sign in to comment.