Disable dask query-planning #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also triggered a nightly build from this branch on my fork https://github.com/jdblischak/TileDB-VCF/actions/runs/8269643115 |
awenocur
approved these changes
Mar 13, 2024
|
Nightlies passed on my fork |
Closed
This was referenced Mar 13, 2024
Merged
awenocur
pushed a commit
that referenced
this pull request
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #671
dask 2024.3.0, released two days ago on 2024-03-11, changed the default behavior of
dask.dataframeto require the package dask-expr, but didn't add dask-expr to its default dependenciesSo our options are 1) install dask-expr for all our CI jobs, or 2) disable query-planning. According to @awenocur, we are dropping support for dask in the next couple of months, so the choice doesn't matter much. I chose option 2 since it required fewer edits.
xref: first discovered in #669 (such bad timing on my part; opened that PR the day dask broke our CI), solution confirmed in #670