-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Account App public views #3453
Merged
kschiffer
merged 10 commits into
feature/1422-account-app
from
feature/1422-account-app-new-groundwork
Dec 4, 2020
Merged
Account App public views #3453
kschiffer
merged 10 commits into
feature/1422-account-app
from
feature/1422-account-app-new-groundwork
Dec 4, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kschiffer
force-pushed
the
feature/1422-account-app-new-groundwork
branch
from
November 9, 2020 17:35
fc0395b
to
ed0cc10
Compare
bafonins
approved these changes
Nov 11, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Reset password view does not show an error when non-existent user id is provided
- Update
jsconfig.json
paths to account for the newaccount
folder - If I navigate to
/oauth/anything
I end up on a broken screen without any errors
kschiffer
force-pushed
the
feature/1422-account-app
branch
from
December 4, 2020 12:27
4d4685b
to
354eeeb
Compare
Looks great! |
kschiffer
force-pushed
the
feature/1422-account-app
branch
from
December 4, 2020 12:40
354eeeb
to
6ffa2f7
Compare
kschiffer
force-pushed
the
feature/1422-account-app-new-groundwork
branch
from
December 4, 2020 16:14
ed0cc10
to
0059c7f
Compare
kschiffer
force-pushed
the
feature/1422-account-app-new-groundwork
branch
from
December 4, 2020 16:28
0059c7f
to
e65af93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the new public views to the account app scaffold
feature/1422-account-app
branch and introduces some related changes and fixes.More screenshots
References #1422
Changes
next
parameter when registering a new account<FullViewError />
Testing
Manual testing and e2e tests.
Regressions
The diff is quite large so there's a good chance that this breaks things. I tried to test everything but I'd still like you to do some monkey testing yourselves. I also updated the e2e tests.
Notes for Reviewers
feature/1422-account-app
which I keep rebased on latest minor. When all parts are added, we will merge this branch into the minor.skip()
since I had to remove the password updating when logged in for now. I will reintroduce it in the upcoming PR, which will add the groundwork for the new authenticated viewsaccount-*.*
tooauth-*.*
in the last PR. This is necessary to ensure config compatibility. I'll fix this in another PR, since there will also be some changes to the branding/assets itself.Checklist
README.md
for the chosen target branch.CHANGELOG.md
.CONTRIBUTING.md
, there are no fixup commits left.