Add Account App #3683
Merged
Add Account App #3683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kschiffer
added
c/console
kschiffer
force-pushed
the
feature/1422-account-app
branch
from
e32214b
to
477f990
Compare
github-actions
bot
added
compat/config
|
Awesome. Works locally. The end-to-end tests are expected to pass, right? Also, can we do something better here still?
|
kschiffer
force-pushed
the
feature/1422-account-app
branch
from
f736ca7
to
4964750
Compare
Yes. Just had to update the RegExp for the mails, which changed today #3678
Yeah, I'll add something. |
kschiffer
force-pushed
the
feature/1422-account-app
branch
from
4964750
to
622bc01
Compare
johanstokking
approved these changes
Jan 20, 2021
htdvisser
approved these changes
Jan 21, 2021
kschiffer
force-pushed
the
feature/1422-account-app
branch
from
622bc01
to
0e1e37f
Compare
bafonins
approved these changes
Jan 21, 2021
| cy.location('pathname').should('eq', `${Cypress.config('oauthRootPath')}/update-password`) | ||
| }) | ||
| cy.location('pathname').should('eq', `${Cypress.config('accountAppRootPath')}/update-password`) | ||
| }).skip() |
There was a problem hiding this comment.
These are the old tests for the authenticated password change, which is currently still missing. I'll unskip them together with the profile settings PR.
| const client = new Client({ | ||
| user: 'root', | ||
| host: 'localhost', | ||
| database: 'ttn_lorawan_dev', |
There was a problem hiding this comment.
not for this PR, but this should be passed from mage. otherwise its hardcoded twice in two different places
kschiffer
force-pushed
the
feature/1422-account-app
branch
from
ea70748
to
766dc97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
References #1422
This PR merges the feature branch
feature/1422-account-appintov3.11. This will add the current state of the new Account App into production. The feature branch is a culmination of various earlier PRs which targeted this feature branch, my ongoing rebasing work throughout the lifetime of this feature branch, as well as additional end-to-end tests for the new Account App.Changes
--is.oauth.ui.console-urlTesting
Since the merges into this feature branch have all gone through the regular PR review process, the individual parts of this branch are already tested. I've added the new end-to-end tests to ensure that all parts also work in conjunction with each other. Additionally, I did quite some manual testing over the last couple of months. This is a big change, so it's almost impossible to check every last detail, but the new e2es should give us some confidence in the integrity of these changes.
Regressions
This PR will completely replace the old oauth app, meaning that all code has been completely rewritten. As such, it is possible that regressions occur. See also the last segment about testing.
Notes for Reviewers
A complete code review should not be necessary, since all parts have already been reviewed. I only introduced additional changes to the extent necessary to integrate changes of the master branch, during rebases.
Like before, in development mode this needs the following additional configuration to work:
What is still missing is respective documentation updates. I'd suggest to successively update those separately.
Checklist
README.mdfor the chosen target branch.CHANGELOG.md.CONTRIBUTING.md, there are no fixup commits left.