Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ruby: rename files/folder & move unused files/folder to archive #23846

Merged
merged 8 commits into from
Mar 22, 2022
Merged

ruby: rename files/folder & move unused files/folder to archive #23846

merged 8 commits into from
Mar 22, 2022

Conversation

01zulfi
Copy link
Member

@01zulfi 01zulfi commented Mar 20, 2022 •
edited

Complete the following REQUIRED checkboxes:

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text

Complete the following checkboxes ONLY IF they are applicable to your PR. You can complete them later if they are not currently applicable:

  • I have previewed all lesson files included in this PR with the Markdown preview tool to ensure the Markdown content is formatted correctly
  • I have ensured all lesson files included in this PR follow the Layout Style Guide

1. Because:

Related to:

  1. Cleaning up folder/file structure in the curriculum repository top-meta#109

2. This PR:

  1. Renames ruby_programming folder to ruby
  2. Renames files/folder to match lesson/section names on the website
  3. Moves future_lessons and git folder to archive
  4. Leaves automated_testing folder alone

3. Additional Information:

n/a

@01zulfi 01zulfi added Status: Do Not Review This issue/PR should not be reviewed until further notice Type: Epic This issue is a larger, unnamed project with several moving parts labels Mar 20, 2022
@01zulfi 01zulfi mentioned this pull request Mar 20, 2022
Merged
3 tasks
@01zulfi 01zulfi added Status: Needs Review and removed Status: Do Not Review This issue/PR should not be reviewed until further notice labels Mar 20, 2022
KevinMulhern
KevinMulhern approved these changes Mar 21, 2022
View reviewed changes
Copy link
Member

@KevinMulhern KevinMulhern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@01zulfi 01zulfi merged commit 0d1da3c into TheOdinProject:main Mar 22, 2022
@01zulfi 01zulfi mentioned this pull request Mar 22, 2022
Closed
4 tasks
@01zulfi 01zulfi deleted the ruby-cleanup branch March 27, 2022 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinMulhern KevinMulhern KevinMulhern approved these changes

Assignees
No one assigned
Labels
Type: Epic This issue is a larger, unnamed project with several moving parts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@01zulfi @KevinMulhern