Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: update ruby lesson urls & rename course to "Ruby" #2744

Merged
merged 4 commits into from
Mar 22, 2022
Merged

Chore: update ruby lesson urls & rename course to "Ruby" #2744

merged 4 commits into from
Mar 22, 2022

Conversation

01zulfi
Copy link
Member

@01zulfi 01zulfi commented Mar 20, 2022 •
edited

Complete the following REQUIRED checkboxes:

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this PR follows the keyword: brief description of change format, using one of the following keywords:
  • Feature - adds new or amends existing user-facing behaviour
  • Chore - changes that have no user-facing value, refactors, dependency bumps, etc
  • Fix - bug fixes

Complete the following checkbox ONLY IF it is applicable to your PR. You can complete it later if it is not currently applicable:

  • I have verified all tests and linters pass against my changes, and/or I have included automated tests where applicable

1. Because:

Related to:

  1. Cleaning up folder/file structure in the curriculum repository top-meta#109
  2. ruby: rename files/folder & move unused files/folder to archive curriculum#23846

2. This PR:

  1. Updates ruby lesson urls based on ruby: rename files/folder & move unused files/folder to archive curriculum#23846
  2. Renames Ruby Programming course title to Ruby

3. Additional Information:

n/a

@01zulfi
update lesson urls in ruby_lessons.rb
fe9b37d 
reason: files/folders were renamed in the curriculum repository
@01zulfi
rename Ruby Programming course to Ruby
81015cd
@01zulfi 01zulfi added Status: Needs Review This issue/PR needs an initial or additional review Type: Chore Involves changes with no user-facing value, to the build process/internal tooling, refactors, etc. Type: Epic This issue is a larger, unnamed project with several moving parts labels Mar 20, 2022
@KevinMulhern KevinMulhern temporarily deployed to odin-ruby-cleanup-8a5tsv0luzl0 March 20, 2022 14:18 Inactive
@KevinMulhern
Copy link
Member

Hey @01zulfi, thanks so much for doing this 💪

There are a couple more small spots we need to update for this as well.

The badges for each course are fetched using the title:
https://github.com/TheOdinProject/theodinproject/blob/main/app/components/progress_badge_component.rb#L29
https://github.com/TheOdinProject/theodinproject/blob/main/app/components/progress_badge_component.rb#L43

Finally, there is a mention of Ruby programming in the readme:
https://github.com/TheOdinProject/theodinproject/blame/main/README.md#L7

@01zulfi
update Ruby Programming mentions in codebase to Ruby
ed671fd 
Files changed:
* progress_badge_component.rb
* README.md
@KevinMulhern KevinMulhern temporarily deployed to odin-ruby-cleanup-8a5tsv0luzl0 March 21, 2022 12:26 Inactive
@01zulfi
Copy link
Member Author

01zulfi commented Mar 21, 2022

Above changes done

@KevinMulhern
Copy link
Member

Changes look good thanks @01zulfi, lets get the curriculum changes merged, then I'll do a quick QA in a review app before merging this PR.

@01zulfi
Copy link
Member Author

01zulfi commented Mar 22, 2022

@KevinMulhern Curriculum changes merged.

@KevinMulhern KevinMulhern temporarily deployed to odin-ruby-cleanup-ud7ompi7qd0i March 22, 2022 13:32 Inactive
@01zulfi
update links to ruby course
461ea0e 
reason: course name is changed to Ruby from Ruby Programming
files changed:
* CONTRIBUTING.md
* app/helpers/application_helper.rb
* app/views/static_pages/dashboard_steps/before_asking.md
@KevinMulhern KevinMulhern temporarily deployed to odin-ruby-cleanup-ud7ompi7qd0i March 22, 2022 14:11 Inactive
KevinMulhern
KevinMulhern approved these changes Mar 22, 2022
View reviewed changes
Copy link
Member

@KevinMulhern KevinMulhern left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @01zulfi, thanks for all your work on this. Merging now to fix the "improve this lesson" links on the ruby course.

@KevinMulhern KevinMulhern merged commit 1fad1e2 into TheOdinProject:main Mar 22, 2022
@01zulfi 01zulfi deleted the ruby-cleanup branch March 27, 2022 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinMulhern KevinMulhern KevinMulhern approved these changes

Assignees
No one assigned
Labels
Status: Needs Review This issue/PR needs an initial or additional review Type: Chore Involves changes with no user-facing value, to the build process/internal tooling, refactors, etc. Type: Epic This issue is a larger, unnamed project with several moving parts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@01zulfi @KevinMulhern