New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHOT revamp #884
base: master
Are you sure you want to change the base?
PHOT revamp #884
Conversation
Add support for conductive elements
tmp == 1 disables PHOT -> ELEC reaction tmp == 2 makes BIZR/G/S impermeable
What is your primary goal with this PR? Is it to add more PHOT colors and have a wavelength defined for all elements? Perhaps to add more interesting PHOT reactions? But anyway, making changes to a well-established element like PHOT has a lot of ramifications, so this PR concerns me a little. If you want to talk about the PR, it would be best to join either the discord or IRC to talk about it with us. (the times when me or LBPHacker are online and active varies so you may need to idle for a bit to get a response). Mainly just concerned about compatibility, and the expansion of the PHOT color space (which is intentionally limited right now). But I'm not even the one that came up with the PHOT color format. Also, there are more elements than just PHOT which use this color format, FILT also does for example. |
(Optional)Move wavelength calculations to Renderer.cpp(or even PHOT.cpp)(Optional)Add new BIZR/G/S tmp mode disabling PHOT -> ELEC reaction and another one disabling passing of PHOT and ELEC