Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHOT revamp #884

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

PHOT revamp #884

wants to merge 9 commits into from

Conversation

Ksawi999
Copy link
Contributor

@Ksawi999 Ksawi999 commented Jan 1, 2023

  • Set PHOT brightness according to its life
  • Change wavelength upon reflecting from most particles
  • Make dcolour affect reflected wavelength
  • Disable wavelength interaction with several particles
  • Remove PhotonReflectWavelengths
  • Implement ability to change PHOT ctype using its dcolour value (deco tool)
  • (Optional) Move wavelength calculations to Renderer.cpp (or even PHOT.cpp)
  • Add tinted GLAS/QRTZ (and their powders) support
  • Get SPRK reflection from its ctype
  • (Optional) Add new BIZR/G/S tmp mode disabling PHOT -> ELEC reaction and another one disabling passing of PHOT and ELEC
  • Get BIZR/G/S and BRAY reflection from their wavelength
  • Move BIZR tmp modes to tmp2 and make better use of tmp
  • Add PHOT reflection modes (all/deco only/no deco/no change) stored in tmp
  • Add new FILT tmp mode for color unpacking
  • Fix PHOT color calculation (rendering is ok)
  • Fix BRAY not rendering its all color gamut properly (it's currently 15 bit with ~1% duplicates but could be turned into 18 bit with ~30% duplicates and that's a huge difference)
  • Backward compatibility
  • Resolve conflicts
  • (Optional) Improve PHOT heat simulation (based on life)
  • (Optional) Make PHOT life decreasing based on pressure (pressure off -> infinite phot)
  • (Optional) Add simulation setting for enabling/disabling new PHOT behavior
  • (Optional) Add support for particles using gradient (automatically implemented with above)
  • (Optional) Move all deco calculations to deco tool (it will remove several reactions, for example CRAY coloring, but slightly increase PHOT simulation speed)
  • (Optional) Readd reactions deleted by above

@jacob1
Copy link
Member

jacob1 commented Jan 11, 2023

What is your primary goal with this PR? Is it to add more PHOT colors and have a wavelength defined for all elements? Perhaps to add more interesting PHOT reactions?

But anyway, making changes to a well-established element like PHOT has a lot of ramifications, so this PR concerns me a little. If you want to talk about the PR, it would be best to join either the discord or IRC to talk about it with us. (the times when me or LBPHacker are online and active varies so you may need to idle for a bit to get a response).

Mainly just concerned about compatibility, and the expansion of the PHOT color space (which is intentionally limited right now). But I'm not even the one that came up with the PHOT color format. Also, there are more elements than just PHOT which use this color format, FILT also does for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants