Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LITH charge serialization with DTEC #896

Closed
wants to merge 1 commit into from

Conversation

Ksawi999
Copy link
Contributor

Why?

  1. It's faster, easier and takes less space.
  2. Forward compatibility - PHOT revamp #884 will probably disable LITH reflection (but only if this PR will be accepted) so this will be the only method of doing that.
  3. It wouldn't break any old save (please correct me if I'm wrong). Even if lith is next to the dtec it's in most cases because the phot will bounce off it resulting in the same wavelength.

@jacob1
Copy link
Member

jacob1 commented Jan 22, 2023

I don't think this is necessary. The previous version already added the PHOT reflection method of detecting charge. We don't need another new method of doing it. I'm not entirely happy with the PHOT method either, but for the same reasons as this one, it's not a very "natural" way of detecting it and relies on FILT tech (this one moreso than the PHOT method).

Your other PR hasn't been accepted yet, and also doesn't remove the PHOT method yet anyway.

@jacob1 jacob1 closed this Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants