Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a pull request template - Issue#302 #329

Open
wants to merge 2 commits into
base: canary
Choose a base branch
from
Open

Added a pull request template - Issue#302 #329

wants to merge 2 commits into from

Conversation

whoiskekeanyway
Copy link

I added a pull request template as per issue #302

@vercel
Copy link

vercel bot commented Jan 12, 2022 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/techphantoms/tech-phantoms/BumidAWWbHV8ippLziDZFRMU9W5r
✅ Preview: https://tech-phantoms-git-fork-whoiskekeanyway-patch-1-techphantoms.vercel.app

@Panquesito7 Panquesito7 added the type: feature Brand new functionality, features, pages, workflows, endpoints, etc. label Jan 12, 2022
Panquesito7
Panquesito7 requested changes Jan 12, 2022
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 🚀
Please move the file to the .github directory. Let us know if you need any help with that!

pull_request_template.md Outdated
Comment on lines 23 to 24


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

pull_request_template.md Outdated

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Fixes # (issue)
Fixes # (issue) <!-- issue number that will be closed through this PR -->

pull_request_template.md Outdated
@@ -0,0 +1,35 @@
# Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
<!-- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. -->

pull_request_template.md Outdated

## Type of change

Please delete options that are not relevant.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Please delete options that are not relevant.
<!-- Please delete options that are not relevant -->

pull_request_template.md Outdated

# How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
<!-- Please describe the tests that you ran to verify your changes. -->
<!-- Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. -->

pull_request_template.md Outdated



# Checklist:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Checklist:
## Checklist

@whoiskekeanyway
Rename pull_request_template.md
97209c9 
Rename pull_request_template.md to .github/pull_ pull_request_template.md
@whoiskekeanyway
Copy link
Author

I have made the changes. Thank you

Great work! 🚀 Please move the file to the .github directory. Let us know if you need any help with that!

I have made the changes. Thank you

Panquesito7
Panquesito7 requested changes Jan 12, 2022
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please check my comments above? Thanks. :)

@whoiskekeanyway
Copy link
Author

Could you please check my comments above? Thanks. :)

I have moved it into the GitHub folder. please explain what I need to do if I am doing it wrong

@Panquesito7
Copy link
Member

Could you please check my comments above? Thanks. :)

I have moved it into the GitHub folder. please explain what I need to do if I am doing it wrong

#329 (review)

@whoiskekeanyway
Copy link
Author

Great work! 🚀 Please move the file to the .github directory. Let us know if you need any help with that!

I need help. i do not understand what i need to do next

@Panquesito7
Copy link
Member

#329 (comment)
#329 (comment)
#329 (comment)
#329 (comment)
#329 (comment)
#329 (comment)

@KendallDoesCoding
Copy link
Contributor

Please link issue #302 to this PR

@whoiskekeanyway whoiskekeanyway mentioned this pull request Feb 22, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Panquesito7 Panquesito7 Awaiting requested review from Panquesito7

Assignees
No one assigned
Labels
type: feature Brand new functionality, features, pages, workflows, endpoints, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@whoiskekeanyway @Panquesito7 @KendallDoesCoding