Revamp Time Cost Feature #4840

cochcoder · 2024-04-01T23:58:35Z

For whatever reason GitHub decided to close the original PR which was #4392, that's why I reopened it here

EDIT: Forgot to add this: closes #3502

Rename total_cost to total_filament_cost Add electric_cost to print_statistics Rename Cost in legend to Filament cost as well as changing print statistic used

Re add electric_cost to print_statistics Add total_filament_cost & electric_cost to PrintStatistics in Print.hpp

Note to self, most likely will need to replace c_str with something

Renamed electric_cost, in most areas, to kWh_cost to fix a bug Created a formula for calculating the total cost

If the user enters both the electric consumption and kWh price then separate costs will be shown.

This reverts commit 915c731.

This reverts commit 647e5c2.

This reverts commit 1dee130.

This reverts commit 3142d3a.

This reverts commit 3d92a5a.

This reverts commit 46b2922.

SoftFever · 2024-04-14T09:09:40Z

src/libslic3r/Fill/FillRectilinear.cpp

@@ -2564,10 +2564,10 @@ static std::vector<MonotonicRegionLink> chain_monotonic_regions(
 		}

 		// Reinforce the path pheromones with the best path.
-        float total_cost = best_path_length + float(EPSILON);
+        float total_filament_cost = best_path_length + float(EPSILON);


can you revert the changes here?

SoftFever · 2024-04-14T09:09:48Z

src/libslic3r/Fill/FillRectilinear.cpp

        for (size_t i = 0; i + 1 < path.size(); ++ i) {
            MonotonicRegionLink &link = path[i];
-            link.next->pheromone = (1.f - pheromone_evaporation) * link.next->pheromone + pheromone_evaporation / total_cost;
+            link.next->pheromone = (1.f - pheromone_evaporation) * link.next->pheromone + pheromone_evaporation / total_filament_cost;


can you revert the changes here?

SoftFever · 2024-04-14T09:20:30Z

@cochcoder
Thank you for your patience.

I'm not very sure about how useful it is, especially since the electricity cost largely depends on the type of filament used. The electricity consumption varies significantly between printing ABS and printing PLA. It's probably more practical to consider the cost within the filament expenses instead. It seems a bit like over-engineering to further break down the costs and clutter the UI.

Hence, I'm inclined not to include the changes.

FillPavS · 2024-04-16T05:54:50Z

@cochcoder Thank you for your patience.

I'm not very sure about how useful it is, especially since the electricity cost largely depends on the type of filament used. The electricity consumption varies significantly between printing ABS and printing PLA. It's probably more practical to consider the cost within the filament expenses instead. It seems a bit like over-engineering to further break down the costs and clutter the UI.

Hence, I'm inclined not to include the changes.

Previously, there was a function for calculating the price depending on the amount of plastic used and the operating time of the printer. Now it does not take into account the operating time of the printer. The field where you can specify the price remains in the printer settings, but it does not affect anything.

cochcoder · 2024-04-16T17:43:06Z

@cochcoder

Thank you for your patience.

I'm not very sure about how useful it is, especially since the electricity cost largely depends on the type of filament used. The electricity consumption varies significantly between printing ABS and printing PLA. It's probably more practical to consider the cost within the filament expenses instead. It seems a bit like over-engineering to further break down the costs and clutter the UI.

Hence, I'm inclined not to include the changes.

I see where you're coming from, I'm going to mark this as a draft for now, as I want to look into possibly making a more accurate electricity cost calculator, and see how useful this PR would be in the future.

cochcoder · 2024-04-16T17:45:04Z

@cochcoder Thank you for your patience.

I'm not very sure about how useful it is, especially since the electricity cost largely depends on the type of filament used. The electricity consumption varies significantly between printing ABS and printing PLA. It's probably more practical to consider the cost within the filament expenses instead. It seems a bit like over-engineering to further break down the costs and clutter the UI.

Hence, I'm inclined not to include the changes.

Previously, there was a function for calculating the price depending on the amount of plastic used and the operating time of the printer. Now it does not take into account the operating time of the printer. The field where you can specify the price remains in the printer settings, but it does not affect anything.

I'm confused on what you mean as the cost calculator in place right now does take the time of the print into account.

FillPavS · 2024-04-16T17:49:05Z

@cochcoder Thank you for your patience.

I'm not very sure about how useful it is, especially since the electricity cost largely depends on the type of filament used. The electricity consumption varies significantly between printing ABS and printing PLA. It's probably more practical to consider the cost within the filament expenses instead. It seems a bit like over-engineering to further break down the costs and clutter the UI.

Hence, I'm inclined not to include the changes.

Previously, there was a function for calculating the price depending on the amount of plastic used and the operating time of the printer. Now it does not take into account the operating time of the printer. The field where you can specify the price remains in the printer settings, but it does not affect anything.

I'm confused on what you mean as the cost calculator in place right now does take the time of the print into account.

It used to work, but not now. I can specify any printing cost in the printer settings, even 1000000, but this is not added to the price of plastic in the final calculation.

cochcoder · 2024-04-16T18:01:05Z

I'm not having this issue, can you send a screen recording of you replicating this issue?

FillPavS · 2024-04-16T18:11:07Z

I'm not having this issue, can you send a screen recording of you replicating this issue?

The built-in screen recording in Windows records only the active window. I had to record it from my phone. I hope it's clear what's going on there)
video - https://cloud.mail.ru/public/sLkn/7gRwY8NRi

cochcoder and others added 30 commits March 8, 2024 19:19

Add electric_consumption & electric_cost

c3800bf

Change time_cost to electric_consumption & add electric_cost

6c28d4f

Add electric_consumption & electric_cost

894913f

Add electric_consumption & electric_cost

2e5242c

Update total cost caculator

6d7cc68

Fix total_cost caculator

887819b

Attempt at fixing incorrect cost calculation

52478fe

Slight tidying up

720b9a0

Merge branch 'SoftFever:main' into main

e227687

Add electric cost section to legend

bb83dec

Misc.

c25372f

Rename total_cost to total_filament_cost Add electric_cost to print_statistics Rename Cost in legend to Filament cost as well as changing print statistic used

Hopefully this fixes failed builds

6665bd8

Merge branch 'main' into main

39953b0

Fix failed builds attempt 2

d5be7a7

Re add electric_cost to print_statistics Add total_filament_cost & electric_cost to PrintStatistics in Print.hpp

Merge branch 'SoftFever:main' into main

cc3a1a2

Replace total_cost with total_filament_cost

69308cc

Forgot to replace this...

626f1e1

Edit legend

6412a38

Merge branch 'SoftFever:main' into main

a3a83b1

Forgot this one

00e6c12

Note to self, most likely will need to replace c_str with something

Add Total Cost to legend

e4770fe

Renamed electric_cost, in most areas, to kWh_cost to fix a bug Created a formula for calculating the total cost

Add Filament cost & Electric cost to All Plates Stats

292672d

Attempt at fixing failed builds

80da975

Remove redundant declaration of buf

594508f

Add if statment

dcc93d3

If the user enters both the electric consumption and kWh price then separate costs will be shown.

Oops

e5cf92c

Syntax errors

3b02513

Some fine tuning

0a7b057

Unneeded +

ae779f0

Merge branch 'SoftFever:main' into main

a27527c

cochcoder added 18 commits March 11, 2024 23:02

Maybe this?

1dee130

Merge branch 'SoftFever:main' into main

d0b574a

Trying two changes

647e5c2

Maybe this?

915c731

Revert "Maybe this?"

1f822fa

This reverts commit 915c731.

Revert "Trying two changes"

5299711

This reverts commit 647e5c2.

Revert "Maybe this?"

5ae545e

This reverts commit 1dee130.

Revert "Hopefully this works..."

cacf895

This reverts commit 3142d3a.

Revert "Fix failed builds...again"

e277486

This reverts commit 3d92a5a.

Revert "Attempt at adding a currency field"

a17e552

This reverts commit 46b2922.

Fix bug

dcb5637

Merge branch 'SoftFever:main' into main

cff1069

Merge branch 'SoftFever:main' into main

e069108

Merge branch 'main' into main

4970a7a

Merge branch 'SoftFever:main' into main

5b60516

Merge branch 'main' into main

b93adf7

Merge branch 'SoftFever:main' into main

e49085d

Merge branch 'SoftFever:main' into time-cost

8f60ed9

cochcoder mentioned this pull request Apr 1, 2024

Revamp time cost feature #4392

Closed

8 tasks

Merge branch 'main' into time-cost

87ad7b4

SoftFever reviewed Apr 14, 2024

View reviewed changes

cochcoder marked this pull request as draft April 18, 2024 01:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Revamp Time Cost Feature #4840

Revamp Time Cost Feature #4840

cochcoder commented Apr 1, 2024 •

edited

SoftFever Apr 14, 2024

SoftFever Apr 14, 2024

SoftFever commented Apr 14, 2024

FillPavS commented Apr 16, 2024

cochcoder commented Apr 16, 2024

cochcoder commented Apr 16, 2024

FillPavS commented Apr 16, 2024

cochcoder commented Apr 16, 2024

FillPavS commented Apr 16, 2024

Revamp Time Cost Feature #4840

Are you sure you want to change the base?

Revamp Time Cost Feature #4840

Conversation

cochcoder commented Apr 1, 2024 • edited

SoftFever Apr 14, 2024

Choose a reason for hiding this comment

SoftFever Apr 14, 2024

Choose a reason for hiding this comment

SoftFever commented Apr 14, 2024

FillPavS commented Apr 16, 2024

cochcoder commented Apr 16, 2024

cochcoder commented Apr 16, 2024

FillPavS commented Apr 16, 2024

cochcoder commented Apr 16, 2024

FillPavS commented Apr 16, 2024

cochcoder commented Apr 1, 2024 •

edited