-
-
Notifications
You must be signed in to change notification settings - Fork 643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revamp time cost feature #4392
Revamp time cost feature #4392
Conversation
I need to split the cost - to see coat for filament amd cost for others (electricity etc) |
Do you mean that the standard time cost feature is the best for you? Or do you mean that you'd like to see the cost of filament and electricity separately in the statistics? |
Separately, because sometimes I need to know the proce for filament, electricity and time stabdalone |
Do you have any idea where the file for the Total Estimation menu would be? |
In the legend (where you can see filament used etc.) |
I was wondering what the file that controls the legend would be located (I haven't dealt with GitHub repos this complex). I think I found the file under src/slic3r/GUI/GCodeViewer.cpp? |
@cochcoder |
Sure! In the printer settings I replaced time cost with electric consumption and electric cost: |
Re add electric_cost to print_statistics Add total_filament_cost & electric_cost to PrintStatistics in Print.hpp
Anyway, just a note. I know that my buddy use time cost feature in a different way. He just set some value (includes electricity cost, maintance cost, cost of his work). So all is cobered by one value. With thia PR this ability is lost. It could be solve with another field and settings. |
I was thinking about having a button so that the user could choose between either the current system or the system I am currently making for this exact reason. However, I'm not sure how I would do this, I'll start looking into it after I get this system working, any pointers on how I would do this would be great! Also, I am marking this PR as a Draft as I didn't realize there would be this many changes. Thank you for all the great feedback! |
I can't figure out how to add a currency option to the code, I may try to add it in a different PR |
Everything should be good now. This might close the issue #3502 |
So currency request will be added later? Thank you |
Yes, I'll add try to add currency later, once I understand more of C++. Thank you for your feedback! |
Would it be preferable to simply reduce this to a "running cost / hr" metric and allow the user to roll in their energy costs / depreciation themselves. While it offer less specific functionality and detail it does reduce the complexity for the user while still providing the same benefit of exposing them to more accurate cost data in the slicer. |
If the user wants to, they can only fill out the other costs field, and it will work the same as the current time cost system. |
@SoftFever Are there any changes you think need to be implemented? |
This would be cool to have in the main program. Hopefully it gets approved. |
I hope so |
Thank you so much for making this feature! What is missing for it to be incorporated into a future build? I am looking forward to using it! |
Nothing should be missing for this to be merged. It is all up to timing now and when it would be best implement a new feature that could have unforeseen bugs. I'm sure that SoftFever has it all planned out. Thank you all for the support, I would have never thought that one of my first PRs would be so liked! |
But the printer consumption is not a static thing. You need to measure it average consumption and with that you can already know the cost per hour: electricity_price_per_watt * printer_average_consumption_watt_in_hour |
Yes, that is true, the system that is from this PR aims to make it easier for others to get a more detailed cost breakdown if they so wish, even though it could be wildly inaccurate, it depends on the print. However, this PR does open the pathway for someone to make an accurate electric consumption calculator and only have to edit one value in this PR while getting all the other features it adds.
That is true, however, most people won't want to go to that extent to get an estimation of their electric cost. Again, this PR is meant to be more of a stepping stone to open the current time cost feature to either being more complex & accurate or just getting the job done (even if it comes at the cost of accuracy) |
For whatever reason this PR was closed by GitHub, I reopened it at #4840 |
I revamped the time cost feature, so that it would be easier and more accessible for beginners to pros. Besides having to estimate the cost per hour, now you'll need to give your wattage per hour and price per kWh instead. I am open to having this as a separate feature from the current time cost system, however, I don't currently know how to do this as I am new to C++.
Any feedback would be appreciated!
To Do: