Expose BPKDividedCard alignment (#1956)

* Expose BPKDividedCard alignment * Update test * Record snapshots * Updated snapshots * Record snapshots * Record snapshots * Updated snapshots * Rerun CI --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Skyscanner · May 8, 2024 · 0ae3c05 · 0ae3c05
1 parent d53ff06
commit 0ae3c05
Show file tree

Hide file tree

Showing 6 changed files with 42 additions and 8 deletions.
diff --git a/Backpack-SwiftUI/Card/Classes/BPKDividedCard.swift b/Backpack-SwiftUI/Card/Classes/BPKDividedCard.swift
@@ -23,20 +23,23 @@ public struct BPKDividedCard<PrimaryContent: View, SecondaryContent: View>: View
     private let primaryContent: PrimaryContent
     private let secondaryContent: SecondaryContent
     private var tapAction: () -> Void = {}
+    private let alignment: HorizontalAlignment
 
     public init(
+        alignment: HorizontalAlignment = .center,
         elevation: BPKCardElevation = .default,
         @ViewBuilder primaryContent: () -> PrimaryContent,
         @ViewBuilder secondaryContent: () -> SecondaryContent
     ) {
+        self.alignment = alignment
         self.elevation = elevation
         self.primaryContent = primaryContent()
         self.secondaryContent = secondaryContent()
     }
 
     public var body: some View {
         BPKCard(padding: .none, elevation: elevation) {
-            VStack(spacing: 0) {
+            VStack(alignment: alignment, spacing: 0) {
                 primaryContent
                 Color(BPKColor.lineColor)
                     .frame(height: 1)
@@ -47,7 +50,7 @@ public struct BPKDividedCard<PrimaryContent: View, SecondaryContent: View>: View
             }
         }
     }
-    
+
     public func onTapGesture(perform: @escaping () -> Void) -> BPKDividedCard {
         var result = self
         result.tapAction = perform
@@ -59,18 +62,18 @@ struct BPKDividedCard_Previews: PreviewProvider {
 
     private static func primaryContent(title: String) -> some View {
         let message =  "Lorem ipsum dolor sit amet, consectetuer adipiscing elit. " +
-            "Aenean commodo ligula eget dolor. Aenean massa."
+        "Aenean commodo ligula eget dolor. Aenean massa."
         return VStack {
             BPKText(title, style: .heading3)
             BPKText(message)
                 .lineLimit(3)
         }
     }
-    
+
     private static func secondaryContent() -> some View {
         BPKText("Lorem ipsum dolor sit amet")
     }
-    
+
     // swiftlint:disable closure_body_length
     static var previews: some View {
         ZStack {
@@ -83,26 +86,34 @@ struct BPKDividedCard_Previews: PreviewProvider {
                     } secondaryContent: {
                         secondaryContent()
                     }
-                    
+
                     BPKDividedCard(elevation: .focus) {
                         primaryContent(title: "Focused")
                     } secondaryContent: {
                         secondaryContent()
                     }
-                    
+
                     BPKDividedCard(elevation: .none) {
                         primaryContent(title: "Not Elevated")
                     } secondaryContent: {
                         secondaryContent()
                     }
-                    
+
                     BPKDividedCard {
                         primaryContent(title: "Padded")
                             .padding()
                     } secondaryContent: {
                         secondaryContent()
                             .padding()
                     }
+
+                    BPKDividedCard(alignment: .leading) {
+                        primaryContent(title: "Aligned left")
+                            .padding()
+                    } secondaryContent: {
+                        secondaryContent()
+                            .padding()
+                    }
                 }
                 .padding()
             }

diff --git a/Backpack-SwiftUI/Tests/Card/BPKDividedCardTests.swift b/Backpack-SwiftUI/Tests/Card/BPKDividedCardTests.swift
@@ -98,4 +98,19 @@ class BPKDividedCardTests: XCTestCase {
             }
         )
     }
+
+    func testDividedCardWithLeadingAlignment() {
+        assertSnapshot(
+            ZStack {
+                Color(BPKColor.canvasContrastColor)
+                    .ignoresSafeArea()
+                BPKDividedCard(alignment: .leading) {
+                    primaryContent(title: "Aligned Leading")
+                } secondaryContent: {
+                    secondaryContent()
+                }
+                .padding()
+            }
+        )
+    }
 }
diff --git a/...apshots__/BPKDividedCardTests/testDividedCardWithLeadingAlignment.dark-mode.png b/...apshots__/BPKDividedCardTests/testDividedCardWithLeadingAlignment.dark-mode.png
diff --git a/...pshots__/BPKDividedCardTests/testDividedCardWithLeadingAlignment.light-mode.png b/...pshots__/BPKDividedCardTests/testDividedCardWithLeadingAlignment.light-mode.png
diff --git a/...d/__Snapshots__/BPKDividedCardTests/testDividedCardWithLeadingAlignment.rtl.png b/...d/__Snapshots__/BPKDividedCardTests/testDividedCardWithLeadingAlignment.rtl.png
diff --git a/Example/Backpack/SwiftUI/Components/Card/DividedCardExampleView.swift b/Example/Backpack/SwiftUI/Components/Card/DividedCardExampleView.swift
@@ -68,6 +68,14 @@ struct DividedCardExampleView: View {
                         secondaryContent()
                             .padding()
                     }
+
+                    BPKDividedCard(alignment: .leading) {
+                        primaryContent(title: "Aligned Left")
+                            .padding()
+                    } secondaryContent: {
+                        secondaryContent()
+                            .padding()
+                    }
                 }
                 .padding()
             }