Merge pull request #1958 from Skyscanner/donburi/DON-491-update-searc…

…h-modal-for-automation [DON-491] Update search modal to fix the test automation
Skyscanner · May 8, 2024 · d53ff06 · d53ff06
2 parents 2364edc + 71f5a34
commit d53ff06
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 1 deletion.
diff --git a/Backpack-SwiftUI/AppSearchModal/Classes/BPKAppSearchModal.swift b/Backpack-SwiftUI/AppSearchModal/Classes/BPKAppSearchModal.swift
@@ -74,7 +74,6 @@ public struct BPKAppSearchModal: View {
         .padding(.top, .base)
         .padding(.bottom, BPKSpacing.none)
         .background(.surfaceDefaultColor)
-        .accessibilityAddTraits(.isModal)
     }
 
     func makeNavigationBar(

diff --git a/Backpack-SwiftUI/SearchInputSummary/Classes/BPKSearchInputSummary.swift b/Backpack-SwiftUI/SearchInputSummary/Classes/BPKSearchInputSummary.swift
@@ -65,6 +65,7 @@ public struct BPKSearchInputSummary: View {
                 .focused($focused)
                 .accessibilityAddTraits(.isSearchField)
                 .accessibilityLabel(placeholder)
+                .accessibilityIdentifier("search_field")
             accessory
         }
         .frame(maxWidth: .infinity, minHeight: 48.0)

diff --git a/Backpack-SwiftUI/SearchInputSummary/README.md b/Backpack-SwiftUI/SearchInputSummary/README.md
@@ -67,3 +67,6 @@ BPKSearchInputSummary(inputPrefix: .icon, text: $text)
 ```swift
 BPKSearchInputSummary(inputPrefix: .customText("From"), text: $text)
 ```
+
+### UI Testing
+To use the component in UI or smoke tests it's possible to access this element using the accessibility identifier: `search_field`