Document how addons can listen for file changes #1972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyw8
approved these changes
May 1, 2024
There was a problem hiding this comment.
Looks good to me but I'd like @vinistock to check it over too.
andyw8
added
the
server
andyw8
reviewed
May 1, 2024
Earlopain
force-pushed
the
addons-file-watching
branch
from
c5e2443
to
4aab768
Compare
|
I will redo updating the activate methods to take the global state after #1998 is merged so there are no conflicts. |
vinistock
approved these changes
May 2, 2024
|
Thank you for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Addons may want to listen for changes to files and do something about it.
ruby-lsp-railsfor example listens forstructure.sqlto restart the rails runner for updated column information, after Shopify/ruby-lsp-rails#341 is merged.ruby-lspitself wants to check for changes to the rubocop config in the server to resolve #1457rubyfmtforruby-lsp-rubyfmtappears to change behaviour depending on.gitignoreand.rubyfmtignore.I noticed that some activation methods didn't yet take the global state in the docs here . I've updated these in a separate commit here.