Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rubocop-md to lint markdown snippets with Ruby code #2003

Merged
merged 1 commit into from May 2, 2024

Conversation

Earlopain
Copy link
Contributor

Motivation

As per #1972 (comment). Running RuboCop over code in markdown at least prevents basic errors. It did catch a missing end keyword which is nice.

rubocop-md is part of the RuboCop org: https://github.com/rubocop/rubocop-md

@Earlopain Earlopain requested a review from a team as a code owner May 2, 2024 16:36
@Earlopain Earlopain requested review from andyw8 and st0012 May 2, 2024 16:36
.rubocop.yml Outdated Show resolved Hide resolved
.rubocop.yml Outdated Show resolved Hide resolved
@andyw8
Copy link
Contributor

andyw8 commented May 2, 2024

Thanks, this is a very useful addition.

Copy link
Member

@st0012 st0012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL rubocop-md 👍

Copy link
Member

@st0012 st0012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops meant to approve.

@st0012 st0012 added documentation Improvements or additions to documentation chore Chore task labels May 2, 2024
@andyw8 andyw8 merged commit 94194d8 into Shopify:main May 2, 2024
23 of 24 checks passed
@Earlopain Earlopain deleted the rubocop-md branch May 3, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Chore task documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants