Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ERB Support #1184

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Add ERB Support #1184

wants to merge 7 commits into from

Commits on Apr 12, 2024

  1. Introduce ERBDocument

    @marcoroth
    marcoroth committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    caf4ef5 View commit details
    Browse the repository at this point in the history

  2. Add RubyLsp::ERBDocument#scan

    @marcoroth
    marcoroth committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    be1d019 View commit details
    Browse the repository at this point in the history

  3. Handle Jump to definition and hover requests in ERB

    @marcoroth
    marcoroth committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    721d087 View commit details
    Browse the repository at this point in the history

  4. Use RubyLsp::DependencyDetector#typechecker_for_uri? for dependend … 

    …requests
    @marcoroth
    marcoroth committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    2f6edd2 View commit details
    Browse the repository at this point in the history

  5. Don't log output in ERBDocument#scan

    @marcoroth
    marcoroth committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    a8e927b View commit details
    Browse the repository at this point in the history

  6. Move erb? to Support::Common module and address RuboCop warnings

    @marcoroth
    marcoroth committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    fca974d View commit details
    Browse the repository at this point in the history

  7. Add tests, fix tests, resolve sorbet errors

    @marcoroth
    marcoroth committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    60adc9e View commit details
    Browse the repository at this point in the history