Add ERB Support #1184
Draft
Add ERB Support #1184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 13, 2023
|
This pull request is being marked as stale because there was no activity in the last 2 months |
|
This pull request is being marked as stale because there was no activity in the last 2 months |
|
Hey @marcoroth! What's the status of this one? I'm really wishing that Ruby LSP supported ERB Lint. |
|
We are currently missing the right tools to fully provide really useful support for ERB. This PR only adds super basic support. I guess the question is if we want to finish up and merge the most minimalistic ERB support (which is implemented here) or if we should wait until we can build the needed tools. I do have some ideas for the tooling and needed infrastructure, but it needs more coordination and work, which is out of scope for this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1055, depends on Shopify/vscode-ruby-lsp#896
Motivation
Implementation
Automated Tests
Manual Tests