Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Value sanitize improvement #554

Merged
merged 39 commits into from May 15, 2024
Merged

Value sanitize improvement #554

merged 39 commits into from May 15, 2024

Conversation

babenek
Copy link
Contributor

@babenek babenek commented May 6, 2024

Description

Please include a summary of the change and which is fixed.

  • Add auth signatures to found in http headers
  • Improved value sanitize in url (hot only http|https may appear in protocol)
  • add escaped tab '\t' case in keyword regex
  • enchancement for benchmark report check workflow
  • small fixes
  • fix a couple FP for doc
  • refactored benchmark workflow

How has this been tested?

Please describe the tests that you ran to verify your changes.

  • UnitTest
  • Benchmark

@babenek babenek changed the title test Valpos Value sanitize improvement May 7, 2024
@Yullia Yullia self-requested a review May 8, 2024 11:54
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.49%. Comparing base (6ebb093) to head (91b4487).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #554   +/-   ##
=======================================
  Coverage   90.48%   90.49%           
=======================================
  Files         129      129           
  Lines        4447     4449    +2     
  Branches      716      716           
=======================================
+ Hits         4024     4026    +2     
  Misses        278      278           
  Partials      145      145           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@babenek babenek marked this pull request as ready for review May 10, 2024 09:20
@babenek babenek requested a review from a team as a code owner May 10, 2024 09:20
Copy link
Contributor

@Yullia Yullia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Copy link
Contributor

@xDizzix xDizzix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@babenek babenek merged commit 32b802c into Samsung:main May 15, 2024
28 checks passed
@babenek babenek deleted the valpos branch May 15, 2024 07:33
@babenek babenek restored the valpos branch May 15, 2024 07:33
@babenek babenek deleted the valpos branch May 15, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants