Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check hit with value position #127

Merged
merged 55 commits into from May 13, 2024
Merged

Check hit with value position #127

merged 55 commits into from May 13, 2024

Conversation

babenek
Copy link
Contributor

@babenek babenek commented May 6, 2024 •
edited

  • skip obfuscation "multi" pattern - the keys were obfuscated already by other markup
  • add some corrections for positions in markup
  • add '--load' param for benchmark to skip scanner run when it produces the same result.
  • add line_end for other scanners - actually, the same line
  • check value strictly when markup has the value positions (not negative values) - fixes Benchmark does not recognize multiple markup for single line #82
  • Separation some rule names in Category. (Google Multi, AWS Multi)
  • enchanced review diff for multiline
  • little refactoring in benchmark

check PR: Samsung/CredSweeper#554

@babenek babenek force-pushed the valpos branch 2 times, most recently from 1f9bccd to 3897061 Compare May 7, 2024 09:49
@babenek babenek mentioned this pull request May 7, 2024
Merged
2 tasks
@Yullia Yullia self-requested a review May 8, 2024 11:55
Yullia
Yullia previously approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@Yullia Yullia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@babenek babenek marked this pull request as ready for review May 10, 2024 08:59
@babenek babenek requested a review from a team as a code owner May 10, 2024 08:59
@babenek babenek requested a review from Yullia May 13, 2024 11:47
Yullia
Yullia approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@Yullia Yullia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@babenek babenek merged commit 353086e into Samsung:main May 13, 2024
3 checks passed
@babenek babenek deleted the valpos branch May 13, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yullia Yullia Yullia approved these changes

@iuriimet iuriimet iuriimet approved these changes

@xDizzix xDizzix Awaiting requested review from xDizzix

@csh519 csh519 Awaiting requested review from csh519

@kmnls kmnls Awaiting requested review from kmnls

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Benchmark does not recognize multiple markup for single line
3 participants
@babenek @Yullia @iuriimet