Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One mode ellipsoid data #1133

Closed
18 tasks done
jadie1 opened this issue Mar 9, 2021 · 13 comments
Closed
18 tasks done

One mode ellipsoid data #1133

jadie1 opened this issue Mar 9, 2021 · 13 comments
Assignees

Comments

@jadie1
Copy link
Contributor

jadie1 commented Mar 9, 2021

Change ellipsoid data to only vary along x axis. Working on the one_mode_ellipsoid branch.

  • Update shape cohort generation code so user can specify which axis should vary
  • Create ellipsoid_1mode data and put on portal with readme (use-case-data-v2/ellipsoid_1mode/)
  • Check ellisoid_1mode into github and remove ellisoid-v0 and ellipsoid_fd-v0
  • Create ellipsoid_1mode_aligned data and put on portal with readme (use-case-data-v2/ellipsoid_1mode_aligned/)
  • Update all use cases
    • Update ellipsoid use case to use ellipsoid_1mode segs
    • Update ellipsoid_cut use case to use ellipsoid_1mode_aligned segs (issue ellipsoid_cut model shows poor correspondence #1104)
    • Update ellipsoid_mesh use case to use ellipsoid_1mode_aligned meshes
    • Update ellipsoid_fd to use ellipsoid_1mode segs
    • Verify ellipsoid_evaluate use case still works as expected
  • Update portal data to have all use case output (all but ellipsoid_cut added issue ellipsoid_cut model shows poor correspondence #1104)
  • Update all notebooks
    • Update getting-started-with-segmentations.ipynb to use ellipsoid_1mode data
    • Update getting-started-with-meshes.ipynb to use ellipsoid_1mode data
    • Update getting-started-with-exploring-segmentations.ipynb to use ellipsoid_1mode data
    • Update getting-started-with-grooming-segmentations.ipynb to use ellipsoid_1mode data
    • Update getting-started-with-shape-cohort-generation.ipynb for changes to shape cohort generation
  • Update documentation for getting-started-with-shape-cohort-generation.ipynb
@jadie1 jadie1 added this to the 6.0 Release (February 2021) milestone Mar 9, 2021
@jadie1 jadie1 self-assigned this Mar 9, 2021
@jadie1
Copy link
Contributor Author

jadie1 commented Mar 9, 2021

@sheryjoe Could you review this and let me know if I missed anything?

@jadie1
Copy link
Contributor Author

jadie1 commented Mar 9, 2021

@akenmorris Since none of the use cases will be using ellipsoid-v0 now I will remove it from github. Should I add the new dataset to github or should we require the users download it from the portal?

@akenmorris
Copy link
Contributor

If it's small enough, it would be great to include it. It's nice to be able to run a use case without logging in. It will just go to LFS.

@jadie1
Copy link
Contributor Author

jadie1 commented Mar 10, 2021

@sheryjoe Do you think we need to replace every video and png in the notebooks? If the output looks similar but a little different is that okay?

@jadie1
Copy link
Contributor Author

jadie1 commented Mar 10, 2021

@sheryjoe Here is an example of the output using the new data compared to the video:
image

Do you think it is okay if the output is similar but not identical? If not we need to start re-recording the ~40 mp4s.

@sheryjoe
Copy link
Contributor

@jadie1 given similar output, i don't think we have to update the videos.

@sheryjoe
Copy link
Contributor

@jadie1 please keep in mind that the ellispoid_fd and ellispoid_cut use cases assume aligned ellipsoids (as far as I recall). They were using ellispoid-v0

@jadie1
Copy link
Contributor Author

jadie1 commented Mar 11, 2021

@jadie1 please keep in mind that the ellispoid_fd and ellispoid_cut use cases assume aligned ellipsoids (as far as I recall). They were using ellispoid-v0

Yes they are now using the ellispoid_1mode_aligned dataset which is essentially the same as ellipsiod_v0, just generated using the shape cohort generator package.

@jadie1
Copy link
Contributor Author

jadie1 commented Mar 11, 2021

Here are the results using the new data.

ellipsoid
image

ellipsoid_fd
image

ellipsoid_mesh
image

ellipsoid_cut
image
(Issue #1104)

@akenmorris
Copy link
Contributor

What branch is this on?

@iyerkrithika21
Copy link
Contributor

What branch is this on?

one_mode_ellipsoid

@akenmorris
Copy link
Contributor

Ok, the only thing remaining is the ellipsoid_cut params?

@iyerkrithika21
Copy link
Contributor

Yes
#1073 (comment)

@jadie1 jadie1 mentioned this issue Mar 16, 2021
9 tasks
@akenmorris akenmorris mentioned this issue Mar 18, 2021
9 tasks
@jadie1 jadie1 closed this as completed Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants