New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
One mode ellipsoid data #1133
Comments
@sheryjoe Could you review this and let me know if I missed anything? |
@akenmorris Since none of the use cases will be using ellipsoid-v0 now I will remove it from github. Should I add the new dataset to github or should we require the users download it from the portal? |
If it's small enough, it would be great to include it. It's nice to be able to run a use case without logging in. It will just go to LFS. |
@sheryjoe Do you think we need to replace every video and png in the notebooks? If the output looks similar but a little different is that okay? |
@sheryjoe Here is an example of the output using the new data compared to the video: Do you think it is okay if the output is similar but not identical? If not we need to start re-recording the ~40 mp4s. |
@jadie1 given similar output, i don't think we have to update the videos. |
@jadie1 please keep in mind that the ellispoid_fd and ellispoid_cut use cases assume aligned ellipsoids (as far as I recall). They were using ellispoid-v0 |
Yes they are now using the ellispoid_1mode_aligned dataset which is essentially the same as ellipsiod_v0, just generated using the shape cohort generator package. |
Here are the results using the new data. ellipsoid_cut |
What branch is this on? |
one_mode_ellipsoid |
Ok, the only thing remaining is the ellipsoid_cut params? |
Yes |
Change ellipsoid data to only vary along x axis. Working on the one_mode_ellipsoid branch.
The text was updated successfully, but these errors were encountered: