Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ellipsoid_cut model shows poor correspondence #1104

Closed
akenmorris opened this issue Mar 4, 2021 · 8 comments · Fixed by #1157
Closed

ellipsoid_cut model shows poor correspondence #1104

akenmorris opened this issue Mar 4, 2021 · 8 comments · Fixed by #1157
Assignees

Comments

@akenmorris
Copy link
Contributor

Here's what I see at the end of ellipsoid_cut. Notice there are swapped particles, etc.

ellipsoid_cut

Ellipsoid_Cut.mp4
@jadie1
Copy link
Contributor

jadie1 commented Mar 9, 2021

Will be fixed for release via issue #1133

@jadie1
Copy link
Contributor

jadie1 commented Mar 9, 2021

@HeavenlyBerserker After updating the ellipsoid data to only have one mode of variation I am still seeing bad correspondence. The shape model correctly predicts only one mode of variation but some of the particles are crossing over each other.
Can you look at the optimization parameters? The new dataset is called "ellipsoid_1mode_aligned". I have changed the ellipsoid_cut use case to use it on the "one_mode_ellipsoid" branch.

@HeavenlyBerserker
Copy link
Contributor

@jadie1 I'll look at it on Thursday. Thanks for the note.

@sheryjoe
Copy link
Contributor

@HeavenlyBerserker @jadie1 is this issue resolved?

@HeavenlyBerserker
Copy link
Contributor

To the best of my knowledge, yes.

@jadie1
Copy link
Contributor

jadie1 commented Mar 18, 2021

The PR is using the old data still, it should be using ellipsoid_1mode_aligned. I am still seeing particles switch when the iterations are increased. I have tried a lot of different params and have had no luck so far...

@jadie1
Copy link
Contributor

jadie1 commented Mar 18, 2021

That was with 128 particles though. I will test with the new params on the one_mode_ellipsoid branch which uses the new data. If that looks good then we can close this

@jadie1
Copy link
Contributor

jadie1 commented Mar 18, 2021

image
Looks good, packing isn't super uniform but no particles are switching. Closing this now.

@jadie1 jadie1 closed this as completed Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants