One mode ellipsoid #1158
Closed
One mode ellipsoid #1158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pecohortgen description
|
related to #1082? |
|
Trying to figure out why a 100mb zip file was committed to this branch instead of git-lfs. You don't have git-lfs installed? |
|
See #1162 for PR without large file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes all ellipsoid examples to use new ellipsoid data generated via the shape cohort generator which only varies along the x radius. Addresses issue #1133
Testing required:
When the new data on the portal (ellipsoid_1mode and ellipsoid_1mode_aligned) have the expected output from all use cases except ellipsoid_cut (PR #1157)