Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

usockets and uwebsockets needs update to latest #17910

Open
Tracked by #17807
mwoehlke-kitware opened this issue Sep 13, 2022 · 7 comments · Fixed by #17926, #18259 or #18516
Open
Tracked by #17807

usockets and uwebsockets needs update to latest #17910

mwoehlke-kitware opened this issue Sep 13, 2022 · 7 comments · Fixed by #17926, #18259 or #18516
Assignees
Labels
component: build system Bazel, CMake, dependencies, memory checkers, linters priority: medium type: cleanup

Comments

@mwoehlke-kitware
Copy link
Contributor

mwoehlke-kitware commented Sep 13, 2022

uwebsockets needs to be updated to the latest release. The build is failing:

external/uwebsockets/src/App.h:90:62: error: static assertion failed: Mismatching uSockets/uWebSockets ABI
   90 |     static_assert(sizeof(struct us_socket_context_options_t) == sizeof(SocketContextOptions), "Mismatching uSockets/uWebSockets ABI");

It looks like the latest µWebSockets may depend on an unreleased µSockets? (The latest µSockets release is Sept 2021. There should perhaps also be a note that these packages should update in tandem in the relevant repository.bzl(s)?)

Note also that new_release.py is not currently working on usockets due to sigmavirus24/github3.py#1105.

@jwnimmer-tri
Copy link
Collaborator

From a Drake policy perspective, it's a slight preference to use tagged releases when possible, but failing that it's a-ok to use a random git sha.

@mwoehlke-kitware
Copy link
Contributor Author

The update is also apparently causing *san failures. Will need someone to do more digging.

@jwnimmer-tri
Copy link
Collaborator

FYI

Note also that new_release.py is not currently working on usockets due to sigmavirus24/github3.py#1105.

As of today, the latest usockets & uwebsockets do have an author (vs being anonymous), so that bug is no longer in play.

@jwnimmer-tri
Copy link
Collaborator

It looks like the latest µWebSockets may depend on an unreleased µSockets?

uNetworking/uSockets#188

@jwnimmer-tri
Copy link
Collaborator

jwnimmer-tri commented Nov 9, 2022

See #18289.

The next step here is to write a Python integration test that spawns nginx as a subprocess, launches Meshcat using a proxy, and does and automated end-to-end test.

@RussTedrake
Copy link
Contributor

RussTedrake commented Nov 10, 2022

I've just tested the new nightlies by running the first cells of "authoring multibody simulations" tutorial on a fork of the tutorials on deepnote, and confirm that when I try to open the url printed by StartMeshcat, I see:

  • jammy-20221107 works fine (meshcat appears)
  • jammy-20221108 fails with bad gateway
  • jammy-20221109 fails with bad gateway
  • jammy-20221110 works fine.

So i do think that #18259 caused meshcat to stop working on deepnote.

@BetsyMcPhail BetsyMcPhail changed the title uwebsockets needs update to latest usockets and uwebsockets needs update to latest Dec 2, 2022
@jwnimmer-tri
Copy link
Collaborator

jwnimmer-tri commented Feb 9, 2023

Re-opened via the revert #18755.

Reminder of: #17910 (comment). Next step is a regression test, not an upgrade.

See #18289 (comment) for an acceptance test.

@jwnimmer-tri jwnimmer-tri reopened this Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment