New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add week_start parameter to round.IDate #6025
base: round-idate-yday
Are you sure you want to change the base?
Conversation
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite. This stack of pull requests is managed by Graphite. Learn more about stacking. Join @MichaelChirico and the rest of your teammates on Graphite |
IINM it seems we have a situation where we can define WDYT about this @jangorecki? It seems OK to me (having a feature which is only available for certain R version). |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## round-idate-yday #6025 +/- ##
=================================================
Coverage 97.53% 97.53%
=================================================
Files 80 80
Lines 14915 14915
=================================================
Hits 14547 14547
Misses 368 368 ☔ View full report in Codecov by Sentry. |
seems OK to me as well |
NB: Keep this as draft until any R version supporting |
Quite unfortunately, this doesn't work --
round()
MUST have exactly two arguments. See?Math2
of whichround()
andsignif()
are the only (current) members.Relevant
r-devel
thread very recently about how uselessround.Date()
is:https://stat.ethz.ch/pipermail/r-devel/2024-February/083182.html
Directly relevant
r-devel
thread from a few years ago about extending theround()
generic:https://stat.ethz.ch/pipermail/r-devel/2021-January/080427.html