Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix round.IDate behavior for "weeks" #6024

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MichaelChirico
Copy link
Member

@MichaelChirico MichaelChirico commented Mar 27, 2024

Re-push of #4334. Related issue: #4335

I plan to follow this up with further improvements to this method, which seems pretty broken to me at the moment.

Copy link
Member Author

MichaelChirico commented Mar 27, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MichaelChirico and the rest of your teammates on Graphite Graphite

@MichaelChirico MichaelChirico changed the title fix round.IDate behavior fix round.IDate behavior for "weeks" Mar 27, 2024
@MichaelChirico MichaelChirico changed the title fix round.IDate behavior for "weeks" Fix round.IDate behavior for "weeks" Mar 27, 2024
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.53%. Comparing base (566bff0) to head (7f767a0).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6024   +/-   ##
=======================================
  Coverage   97.53%   97.53%           
=======================================
  Files          80       80           
  Lines       14915    14915           
=======================================
  Hits        14547    14547           
  Misses        368      368           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichaelChirico
Copy link
Member Author

I might hold off on this pending #6025 -- if we don't have a week_start parameter then I find round.Date()/round.IDate() to be pretty hopeless and would push for deprecation in favor of trunc.IDate().

@MichaelChirico MichaelChirico added this to the 1.16.0 milestone Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant