Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue834 modular ahu #1437

Open
wants to merge 67 commits into
base: development
Choose a base branch
from
Open

Issue834 modular ahu #1437

wants to merge 67 commits into from

Conversation

KremerMartin
Copy link
Contributor

PR for implementing the new ahu model for HOM and ROM into development
See also #834

martinkremer and others added 30 commits January 9, 2020 09:09
@martinkremer
Create new branch, add empty package for modular AHU
3b18e94
@martinkremer
Provide first version of modular ahu.
8bdd32b
@martinkremer
Adapt unit tests. fixes bug in wrong correlation. [skip ci]
fe1a9c7
typo
17862aa
add test cases to compare the model based on state machines and the m…
e8dae65 
…odular model
@martinkremer
Fixing some bugs. Adding example for cooling to dewpoint if dehumidif…
ab302ba 
…ication is needed.
@martinkremer
adds PartialHumidifier [ci skip]
193efba
@martinkremer
changes limitation in plateheatexchanger [ci skip]
544fdb1
@martinkremer
WIP: adds modular AHU [ci skip]
cd4281f
@martinkremer
adds simple fan model, adds output of heat flow to hea, hum, coo [ski…
dcdffe6 
…p ci]
@martinkremer
updates modular air handling unit For #834 [skip ci]
9d9941b
move two connections into an "if" condition and add visibility options
822bf23
correct connection
d22255e
move two connections into an "if" condition and add visibility option…
f040326 
…s [skip ci]
@martinkremer
[skip ci] Updates UnitTests and removes bug in PartialCooler.mo and S…
4681361 
…prayHumidifier.mo

For #834
@martinkremer
[skip ci] updates icon for example ahus
769c265
@martinkremer
[skip ci] deletes old fan models, updates examples and unit tests due…
2fe2e03 
… to deletion
@martinkremer
[skip ci] Adds model for pass through if one component is not used in…
a2980eb 
… ahu

For #834
@martinkremer
[skip ci] Reworks the modular air handling unit model.
107ddca
@martinkremer
[skip ci] adds parameters for air handling unit
d3abaf0 
For #834
@martinkremer
Changes control of heat recovery system
639251f 
For #834
@martinkremer
Changes calculation of outlet temperature for cooler when dehumidific…
ba5f443 
…ation is acitve.

Adds comparison tests for sensible cooling and dehumidification

For #834
@martinkremer
Adds Example for only humidification
e09c147 
For #834

Note: Comparison works well if bug in old ahu model is resolved.
@martinkremer
[skip-ci] Updates water temperature of adiabatic humidifier
25bfaa5 
For #834
[skip-ci] Add an example for the only heating case
cbbe90d
[skip-ci] correct typo
f136279
@martinkremer
Implements limit for spray humidifier (not exceeds saturation)
9328123 
For # 834
@martinkremer
Merge branch 'issue834_modularAHU' of https://github.com/RWTH-EBC/AixLib
c0f7fdc 
 into issue834_modularAHU
Merge branch 'issue834_modularAHU' of https://github.com/RWTH-EBC/AixLib
bbb9669 
 into issue834_modularAHU
@martinkremer
[skip-ci] Updates limits of spray-humidifier to work with mass flow r…
0db09bd 
…ate of water as well

For #834
PatrickHenkel1 and others added 16 commits May 30, 2022 15:16
@PatrickHenkel1
Updated Validation UseCases for ModularAHU
c1b10fb
@PatrickHenkel1
Updated UnitTest for Spray and Steam Humidifier in ModularAHU
96f0db1 
Added Validation UseCases for ModularAHU
[skip-ci] #834 add a new control module for cooler or sensible cooler
6ecc701
@martinkremer
[skip-ci] Update cooler model.
f9be82d
@martinkremer
Merge branch 'issue834_modularAHU' of https://github.com/RWTH-EBC/AixLib
1ecc03b 
 into issue834_modularAHU
@martinkremer
[skip-ci] Update AHU due to changes in cooler model
b496e93
@martinkremer
[ski-ci] WIP: Update cooler and cooler control
4a8ed93
@PatrickHenkel1
Updated Validation due to changes in ModularAHU
f8d8045
@PatrickHenkel1
Updated conversion from relToAbsHum and absToRelHum
9e546fb 
Using components of AixLib.ThermalZones.ReducedOrder.Multizone.BaseClasses
Merge branch 'issue834_modularAHU' into issue834_modularAHU
1678425
[skip-ci] delete an unnecessary file
d350aad
@PatrickHenkel1
Changed control of cooler from Controler/ControlerCoolerPID to Contro…
261ea08 
…ler/ControlerCooler, because Controler/ControlerCoolerPID was too aggresive and was applying dehumidification even when not necessary

Changed Controler/ControlerCooler to work with current implementation of the cooler
@PatrickHenkel1
Merge branch 'issue834_modularAHU' of https://github.com/RWTH-EBC/AixLib
1d3cc22 
 into issue834_modularAHU
@PatrickHenkel1
Bug fix in controler cooler
2aa4a5f
@PatrickHenkel1
Adjusted calculations: now differentiation between wet and dry air ma…
2c35f06 
…ss flow rate
@PatrickHenkel1
Added enthalpy of condensed water to energy balance in PartialCooler.mo
0c206eb 
Bug Fix in Cooler.mo: saturation pressure is now calculated with T_airOut and not with T_set anymore (important if T_airIn is smaller than T_set)
@KremerMartin KremerMartin self-assigned this Jun 6, 2023
@KremerMartin
Merge development into issue834
db96261
@KremerMartin
Delete auto-generated strings in package.mo
d2984df
@KremerMartin
[skip-ci] Update models to new structure of units in Modelica-Lib.
9775ca3 
For #834
@KremerMartin
[skip-ci] Update SensibleCooler due to deletion of heat transfer models
be2cbdd 
For #834
@KremerMartin
[skip-ci] Delete heat transfer models, add posiility to define heat flow
f9cdeb3 
For #834
@KremerMartin
[skip-ci] Change input of humidifier to part load variable
f0f30f7 
For #834
@KremerMartin
[skip-ci] Change name of heat recovery; delete non-fixed hrs
d1d3035 
For #834
@KremerMartin
[skip-ci] Delete non-fixed hrs
33b6b58 
For #834
@KremerMartin
[skip-ci] Update ModularAHU due to changes before. Delete ExampleAHUs
0f1b18e 
For #834
@KremerMartin
[skip-ci] Fix bug in PartialHeater
8110c61 
For #834
@KremerMartin
[skip-ci] Rename validation package; delete old test cases
64b9488 
For #834
@KremerMartin
[skip-ci] delete old example and unit test files
fc9daa6 
For #834
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@KremerMartin KremerMartin

Labels
hackday
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@KremerMartin @YingXC @martinkremer @ebc-aixlib-bot @PatrickHenkel1