-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue1223 new storage examples #1307
Open
LauraMaier
wants to merge
112
commits into
main
Choose a base branch
from
issue1223_NewStorageExamples
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 36 commits
Commits
Show all changes
112 commits
Select commit
Hold shift + click to select a range
a2149d0
Add conversion script for renaming #1171 [skip ci]
LauraMaier 4bdc81f
Change version number in AixLib #1171 [skip ci]
LauraMaier 612b155
Rename storage models #1171 [skip ci]
LauraMaier 2fbb2af
Adapt package order #1171 [skip ci]
LauraMaier fce547e
Automatic path change in example models #1171 [skip ci]
LauraMaier c8aebd7
Adapt documentation to increase comprehensibility #1171 [skip ci]
LauraMaier 080200b
Add temperature sensors in simple storage #1171
LauraMaier 5d38fd0
ci_correct_html
ebc-aixlib-bot f2d1b77
Merge pull request #1225 from RWTH-EBC/Correct_HTML_issue1171_Storage…
LauraMaier 4027ea0
Change used class in geothermal example #1171
LauraMaier 6378d97
Adapt name of data base due to renaming of bufferStorage [skip ci] #1171
LauraMaier 03d3e4d
Adapt conversion script for new data base record #1171
LauraMaier 7f709c7
Replace HC1 to old position and change path to data base #1171
LauraMaier fbe8d82
Merge branch 'development' into issue1171_StorageSpringCleaning
LauraMaier 7508612
Adapt baseData in partialHeatTransfer #1171
LauraMaier 1066f23
Adapt conversion script and rename example #1171
LauraMaier 81249b4
Adapt simulate and plot script to new name #1171 [skip-ci]
LauraMaier 74ec10e
Add simulate and plot script #1171
LauraMaier 9810289
Add simulate and plot scripts for storage related examples #1171
LauraMaier 823eba6
Automatic push of CI with new regression reference files.Please pull …
ebc-aixlib-bot 61b730c
Replace obsolete pump and valve models in example model #1171 "ci_upd…
LauraMaier ec7f364
Replace obsolete pump model in StorageBoiler example #1171 "ci_update…
LauraMaier 0d61e63
Automatic push of CI with updated or new regression reference files.P…
ebc-aixlib-bot 6fc9854
Merge branch 'IBPSA_Merge' into issue1171_StorageSpringCleaning
LauraMaier 9a26a02
Merge branch 'IBPSA_Merge' into issue1171_StorageSpringCleaning #1171
LauraMaier 2000641
Refactor SI units path in storage models #1171
LauraMaier 643f429
Add conversion script and update version #1171
LauraMaier 7c033a6
Add conversion script #1171
LauraMaier 6b22338
Adapt conversion script #1171
LauraMaier 4fea999
Delete Medium model due to double declaration #1171
LauraMaier 8bda225
Adapt white list for CI #1171
LauraMaier 4f46a9a
Merge branch 'issue1171_StorageSpringCleaning' into issue1223_NewStor…
LauraMaier ad99c48
Replace Storage in exergy meter example with correct path #1171
LauraMaier 9d0a6d3
Add example for simple storage #1223
LauraMaier c2f454b
Adapt specific heat capacity #1223 [skip ci]
LauraMaier ea1f35f
Add simulate and plot script #1223 [skip ci]
LauraMaier 3adddb2
Add pressure drops #1223
LauraMaier b5e83bf
Merge branch 'development' into issue1171_StorageSpringCleaning
LauraMaier 92c7431
Add conversion script and update AL version #1171
LauraMaier 1b542fe
Merge branch 'development' into issue1223_NewStorageExamples
LauraMaier c5cc586
Change all paths to absolute paths and replace PID controller #1223 […
LauraMaier e019b52
Corrected some absolute paths #1223 [skip ci]
LauraMaier 8cea333
Replaced PIDs by AL models rather than MSL #1223 [skip ci]
LauraMaier 1ebf6e3
Refactoring and adding descriptions #1223
LauraMaier 7947ced
Automatic push of CI with new regression reference files.Please pull …
ebc-aixlib-bot dabb343
Merge branch 'development' into issue1171_StorageSpringCleaning
LauraMaier 3829755
Add Storage example on update list "ci_update_ref" #1171
LauraMaier f279c80
Replace wrong storage path in exergy example #1223
LauraMaier 2bfa740
Merge branch 'development' into issue1223_NewStorageExamples
LauraMaier 48488da
Automatic push of CI with updated or new regression reference files.P…
ebc-aixlib-bot b1e05ae
Merge branch 'development' into issue1171_StorageSpringCleaning
LauraMaier 812ab0f
Adapt storage examples to avoid warnings and "ci_update_ref" #1171
LauraMaier f278ae2
Correct simulate and plot script and update ref results "ci_update_re…
LauraMaier 1eb2ecc
Merge branch 'development' into issue1223_NewStorageExamples
LauraMaier d862f12
Automatic push of CI with updated or new regression reference files.P…
ebc-aixlib-bot 20d3cfb
Sloppy change to trigger CI with new reference results "ci_update_ref…
LauraMaier 0fa9af4
Automatic push of CI with updated or new regression reference files.P…
ebc-aixlib-bot e597844
Delete ref results to force CI to create new ones #1223
LauraMaier 3fc5cc5
Automatic push of CI with new regression reference files.Please pull …
ebc-aixlib-bot f24c23f
Merge branch 'issue1171_StorageSpringCleaning' into issue1223_NewStor…
LauraMaier 38b4e76
Adapt initialization #1223
LauraMaier ba57c81
Trigger update of reference results for solar collector example #1223
LauraMaier 1757734
Automatic push of CI with new regression reference files.Please pull …
ebc-aixlib-bot b0570fb
Merge branch 'development' into issue1223_NewStorageExamples
LauraMaier 0e72f33
Adapt simulate and plot script, delete ref results and add initializa…
LauraMaier ae41d8d
Automatic push of CI with new regression reference files.Please pull …
ebc-aixlib-bot df1739e
Refactor paths and delete import SI #1223
LauraMaier 1f23ab7
Delete import SI and change to full paths #1171
LauraMaier e148bd7
Merge branch 'development' into issue1171_StorageSpringCleaning
LauraMaier 9db1100
Merge branch 'development' into issue1223_NewStorageExamples
LauraMaier f00bda7
Merge branch 'development' into issue1171_StorageSpringCleaning
LauraMaier fb08f47
Merge branch 'development' into issue1223_NewStorageExamples
LauraMaier 3851797
Merge branch 'issue1171_StorageSpringCleaning' into issue1223_NewStor…
LauraMaier 6f25b1b
Try revert of date created, an unnecessary commit
b5cd9d1
revert ashrea as well
7b39720
Add full paths #1223
LauraMaier 958a197
Delete unnecessary import AixLib commands #1223
LauraMaier 9a5ed2d
Restructure model and delete faulty assignments in documentation #1223
LauraMaier 03173f1
Adapt faulty reference #1223
LauraMaier d64920a
Add array for output of temperatures for each layer #1223
LauraMaier 44b9501
Add revisions in docu and update simulate and plot script #1223
LauraMaier 04106b0
Merge branch 'development' into issue1223_NewStorageExamples
LauraMaier 5e60ccf
Adapt simulate and plot scripts and update ref results #1223
LauraMaier 3901992
Automatic push of CI with new regression reference files.Please pull …
ebc-aixlib-bot 0e9d003
Add documentation for storage boiler example #1223
LauraMaier ec4ad4e
ci_correct_html
ebc-aixlib-bot 39df81d
Merge pull request #1403 from RWTH-EBC/Correct_HTML_issue1223_NewStor…
LauraMaier 382f0b0
Add revision section and further documentation #1223
LauraMaier 4d5d235
Update simulate and plot script #1223
LauraMaier e80138c
ci_correct_html
ebc-aixlib-bot fe4bfee
Merge pull request #1404 from RWTH-EBC/Correct_HTML_issue1223_NewStor…
LauraMaier 1c3c948
Automatic push of CI with new regression reference files.Please pull …
ebc-aixlib-bot e47cd6a
Revert "ci_correct_html"
ebc-aixlib-bot 51c03d7
Delete import SI and update documentation #1223
LauraMaier e253d18
Adapt html for revisions and delete overview section #1223
LauraMaier 868b3df
delete ugly white space #1223
LauraMaier c7459e1
Reformatting of ugly white spaces #1223
LauraMaier dc8a752
More ugly white spaces #1223
LauraMaier f432824
More and more ugly white spaces #1223
LauraMaier 21eeeee
Revert unintended change in reference results #1223
LauraMaier 4dc0c4c
Revert unintented change in ref results of thermal zone #1223
LauraMaier 47f63a4
Revert unintended change in ref results #1223
LauraMaier 6faa28d
Revert unintended changes in .mos script and update ref results #1223
LauraMaier 1ba2f2c
re-add file [skip-ci]
b9eb08a
Merge branch 'issue1223_NewStorageExamples' of https://github.com/RWT…
25ae341
del file
47b85d7
try correct rename [skip-ci]
267b05c
trigger ci to avoid merge possibility
e4420a2
Correct html manually #1223
LauraMaier 00fe3e7
Correct html manually #1223
LauraMaier 951fd78
Correct more html manually #1223
LauraMaier 8ad40b2
Correct html manually #1223
LauraMaier File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
BufferStorageBaseDataDefinition | ||
StorageDetailedBaseDataDefinition | ||
Generic_New_2000l |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why use import SI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done