Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue1223 new storage examples #1307

Open
wants to merge 112 commits into
base: development
Choose a base branch
from
Open

Issue1223 new storage examples #1307

wants to merge 112 commits into from

Conversation

LauraMaier
Copy link
Contributor

This closes #1223

LauraMaier and others added 30 commits January 27, 2022 13:41
@LauraMaier
Add conversion script for renaming #1171 [skip ci]
a2149d0
@LauraMaier
Change version number in AixLib #1171 [skip ci]
4bdc81f
@LauraMaier
Rename storage models #1171 [skip ci]
612b155
@LauraMaier
Adapt package order #1171 [skip ci]
2fbb2af
@LauraMaier
Automatic path change in example models #1171 [skip ci]
fce547e
@LauraMaier
Adapt documentation to increase comprehensibility #1171 [skip ci]
c8aebd7
@LauraMaier
Add temperature sensors in simple storage #1171
080200b
@ebc-aixlib-bot
ci_correct_html
5d38fd0
@LauraMaier
Merge pull request #1225 from RWTH-EBC/Correct_HTML_issue1171_Storage…
f2d1b77 
…SpringCleaning

Corrected HTML Code in branch Correct_HTML_issue1171_StorageSpringCleaning
@LauraMaier
Change used class in geothermal example #1171
4027ea0
@LauraMaier
Adapt name of data base due to renaming of bufferStorage [skip ci] #1171
6378d97
@LauraMaier
Adapt conversion script for new data base record #1171
03d3e4d
@LauraMaier
Replace HC1 to old position and change path to data base #1171
7f709c7
@LauraMaier
Merge branch 'development' into issue1171_StorageSpringCleaning
fbe8d82
@LauraMaier
Adapt baseData in partialHeatTransfer #1171
7508612
@LauraMaier
Adapt conversion script and rename example #1171
1066f23
@LauraMaier
Adapt simulate and plot script to new name #1171 [skip-ci]
81249b4
@LauraMaier
Add simulate and plot script #1171
74ec10e
@LauraMaier
Add simulate and plot scripts for storage related examples #1171
9810289
@ebc-aixlib-bot
Automatic push of CI with new regression reference files.Please pull …
823eba6 
…the new files before push again. Plottet Results https://ebc.pages.rwth-aachen.de/EBC_all/github_ci/AixLib/issue1171_StorageSpringCleaning/plots/ [skip ci]
@LauraMaier
Replace obsolete pump and valve models in example model #1171 "ci_upd…
61b730c 
…ate_ref"
@LauraMaier
Replace obsolete pump model in StorageBoiler example #1171 "ci_update…
ec7f364 
…_ref"
@ebc-aixlib-bot
Automatic push of CI with updated or new regression reference files.P…
0d61e63 
…lease pull the new files before push again. Plottet Results https://ebc.pages.rwth-aachen.de/EBC_all/github_ci/AixLib/issue1171_StorageSpringCleaning/plots/ [skip ci]
@LauraMaier
Merge branch 'IBPSA_Merge' into issue1171_StorageSpringCleaning
6fc9854
@LauraMaier
Merge branch 'IBPSA_Merge' into issue1171_StorageSpringCleaning #1171
9a26a02
@LauraMaier
Refactor SI units path in storage models #1171
2000641
@LauraMaier
Add conversion script and update version #1171
643f429
@LauraMaier
Add conversion script #1171
7c033a6
@LauraMaier
Adapt conversion script #1171
6b22338
@LauraMaier
Delete Medium model due to double declaration #1171
4fea999
ebc-aixlib-bot and others added 18 commits November 14, 2022 22:33
@ebc-aixlib-bot
ci_correct_html
ec4ad4e
@LauraMaier
Merge pull request #1403 from RWTH-EBC/Correct_HTML_issue1223_NewStor…
39df81d 
…ageExamples

Corrected HTML Code in branch Correct_HTML_issue1223_NewStorageExamples
@LauraMaier
Add revision section and further documentation #1223
382f0b0
@LauraMaier
Update simulate and plot script #1223
4d5d235
@ebc-aixlib-bot
ci_correct_html
e80138c
@LauraMaier
Merge pull request #1404 from RWTH-EBC/Correct_HTML_issue1223_NewStor…
fe4bfee 
…ageExamples

Corrected HTML Code in branch Correct_HTML_issue1223_NewStorageExamples
@ebc-aixlib-bot
Automatic push of CI with new regression reference files.Please pull …
1c3c948 
…the new files before push again. Plottet Results https://ebc.pages.rwth-aachen.de/EBC_all/github_ci/AixLib/issue1223_NewStorageExamples/plots/
@ebc-aixlib-bot @LauraMaier
Revert "ci_correct_html"
e47cd6a 
This reverts commit ec4ad4e.
@LauraMaier
Delete import SI and update documentation #1223
51c03d7
@LauraMaier
Adapt html for revisions and delete overview section #1223
e253d18
@LauraMaier
delete ugly white space #1223
868b3df
@LauraMaier
Reformatting of ugly white spaces #1223
c7459e1
@LauraMaier
More ugly white spaces #1223
dc8a752
@LauraMaier
More and more ugly white spaces #1223
f432824
@LauraMaier
Revert unintended change in reference results #1223
21eeeee
@LauraMaier
Revert unintented change in ref results of thermal zone #1223
4dc0c4c
@LauraMaier
Revert unintended change in ref results #1223
47f63a4
@LauraMaier
Revert unintended changes in .mos script and update ref results #1223
6faa28d
FWuellhorst
FWuellhorst requested changes Nov 17, 2022
View reviewed changes
Copy link
Contributor

@FWuellhorst FWuellhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LauraMaier You somehow deleted the renamed files instead of renaming them. Please change this to keep the file history intact.

AixLib/DataBase/Storage/BufferStorageBaseDataDefinition.mo Show resolved Hide resolved
AixLib/Fluid/Storage/StorageSimple.mo Show resolved Hide resolved
AixLib/Resources/Scripts/Dymola/Fluid/Storage/Examples/StorageBoiler.mos Show resolved Hide resolved
FWuellhorst
FWuellhorst previously approved these changes Nov 18, 2022
View reviewed changes
Copy link
Contributor

@FWuellhorst FWuellhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The local rename does not work for me. I guess one has to do it directly in the correct way, as git already had a history on StorageDetailedBaseDataDefinition now.
But I mean it's not that important!
Thanks for your work. Now let's wait for HTML

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MZuschlag MZuschlag MZuschlag left review comments

@FWuellhorst FWuellhorst FWuellhorst left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@LauraMaier LauraMaier

Labels
None yet
Projects
No open projects
Hackday_07_22
Awaiting triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add examples for StorageDetailed and StorageSimple models
5 participants
@LauraMaier @tosch4 @ebc-aixlib-bot @FWuellhorst @MZuschlag