Issue1171 storage spring cleaning #1226

LauraMaier · 2022-01-28T07:08:03Z

This closes issue #1171

…SpringCleaning Corrected HTML Code in branch Correct_HTML_issue1171_StorageSpringCleaning

FWuellhorst

Nice work! Remove TABS changes and check comments.

AixLib/Fluid/Storage/StorageDetailed.mo

AixLib/Resources/Scripts/ConvertAixLib_from_1.0.2_to_1.0.3.mos

AixLib/Systems/TABS/BaseClasses/TabsBus.mo

FWuellhorst

Nice work. Just the CI now ;)

…the new files before push again. Plottet Results https://ebc.pages.rwth-aachen.de/EBC_all/github_ci/AixLib/issue1171_StorageSpringCleaning/plots/ [skip ci]

…ate_ref"

…_ref"

…lease pull the new files before push again. Plottet Results https://ebc.pages.rwth-aachen.de/EBC_all/github_ci/AixLib/issue1171_StorageSpringCleaning/plots/ [skip ci]

ebc-aixlib-bot · 2022-07-15T04:09:56Z

Errors in regression test. Compare the results on the following page
https://ebc.pages.rwth-aachen.de/EBC_all/github_ci/AixLib/issue1171_StorageSpringCleaning/plots

FWuellhorst · 2022-10-12T14:31:52Z

@LauraMaier : Could you update the branch to MSL 4.0? Then I will add my review.

ebc-aixlib-bot · 2022-10-12T22:43:45Z

Errors in regression test. Compare the results on the following page
https://ebc.pages.rwth-aachen.de/EBC_all/github_ci/AixLib/issue1171_StorageSpringCleaning/plots

ebc-aixlib-bot · 2022-10-12T23:02:09Z

Errors in regression test. Compare the results on the following page
https://ebc.pages.rwth-aachen.de/EBC_all/github_ci/AixLib/issue1171_StorageSpringCleaning/plots

…lease pull the new files before push again. Plottet Results https://ebc.pages.rwth-aachen.de/EBC_all/github_ci/AixLib/issue1171_StorageSpringCleaning/plots/

ebc-aixlib-bot · 2022-10-13T04:41:14Z

Errors in regression test. Compare the results on the following page
https://ebc.pages.rwth-aachen.de/EBC_all/github_ci/AixLib/issue1171_StorageSpringCleaning/plots

ebc-aixlib-bot · 2022-10-13T21:42:20Z

Errors in regression test. Compare the results on the following page
https://ebc.pages.rwth-aachen.de/EBC_all/github_ci/AixLib/issue1171_StorageSpringCleaning/plots

FWuellhorst · 2022-10-14T06:23:44Z

@LauraMaier : Even though the plots dont show, here is the error:

*** Warning: Unspecified initial conditions in 'RunScript("Resources/Scripts/Dymola/Fluid/Storage/Examples/StorageSolarCollector.mos");'.
*** Warning: Unspecified initial conditions in 'RunScript("Resources/Scripts/Dymola/Fluid/Storage/Examples/StorageBoiler.mos");'.

…lease pull the new files before push again. Plottet Results https://ebc.pages.rwth-aachen.de/EBC_all/github_ci/AixLib/issue1171_StorageSpringCleaning/plots/

LauraMaier · 2022-10-17T21:31:03Z

@FWuellhorst Can you re-review? :)

LauraMaier · 2022-10-21T16:57:40Z

@FWuellhorst Will you be able to re-review in October? :) That would be great ! :)

FWuellhorst

Thanks for this cleaning up! Looks good!

LauraMaier and others added 9 commits January 27, 2022 13:41

Add conversion script for renaming #1171 [skip ci]

a2149d0

Change version number in AixLib #1171 [skip ci]

4bdc81f

Rename storage models #1171 [skip ci]

612b155

Adapt package order #1171 [skip ci]

2fbb2af

Automatic path change in example models #1171 [skip ci]

fce547e

Adapt documentation to increase comprehensibility #1171 [skip ci]

c8aebd7

Add temperature sensors in simple storage #1171

080200b

ci_correct_html

5d38fd0

Merge pull request #1225 from RWTH-EBC/Correct_HTML_issue1171_Storage…

f2d1b77

…SpringCleaning Corrected HTML Code in branch Correct_HTML_issue1171_StorageSpringCleaning

LauraMaier requested a review from FWuellhorst January 28, 2022 07:08

LauraMaier self-assigned this Jan 28, 2022

LauraMaier linked an issue Jan 28, 2022 that may be closed by this pull request

Move AixLib.Fluid.Storage.Storage in Obsolete package and rename AixLib.Fluid.Storage.BufferStorage #1171

Open

FWuellhorst requested changes Jan 28, 2022

View reviewed changes

LauraMaier added 4 commits January 28, 2022 08:59

Change used class in geothermal example #1171

4027ea0

Adapt name of data base due to renaming of bufferStorage [skip ci] #1171

6378d97

Adapt conversion script for new data base record #1171

03d3e4d

Replace HC1 to old position and change path to data base #1171

7f709c7

FWuellhorst previously approved these changes Jan 28, 2022

View reviewed changes

LauraMaier added 2 commits March 23, 2022 12:29

Merge branch 'development' into issue1171_StorageSpringCleaning

fbe8d82

Adapt baseData in partialHeatTransfer #1171

7508612

LauraMaier dismissed FWuellhorst’s stale review via 7508612 March 23, 2022 12:22

LauraMaier added 4 commits March 23, 2022 13:32

Adapt conversion script and rename example #1171

1066f23

Adapt simulate and plot script to new name #1171 [skip-ci]

81249b4

Add simulate and plot script #1171

74ec10e

Add simulate and plot scripts for storage related examples #1171

9810289

LauraMaier requested a review from FWuellhorst March 23, 2022 13:23

ebc-aixlib-bot and others added 4 commits March 23, 2022 15:29

Automatic push of CI with new regression reference files.Please pull …

823eba6

…the new files before push again. Plottet Results https://ebc.pages.rwth-aachen.de/EBC_all/github_ci/AixLib/issue1171_StorageSpringCleaning/plots/ [skip ci]

Replace obsolete pump and valve models in example model #1171 "ci_upd…

61b730c

…ate_ref"

Replace obsolete pump model in StorageBoiler example #1171 "ci_update…

ec7f364

…_ref"

Automatic push of CI with updated or new regression reference files.P…

0d61e63

…lease pull the new files before push again. Plottet Results https://ebc.pages.rwth-aachen.de/EBC_all/github_ci/AixLib/issue1171_StorageSpringCleaning/plots/ [skip ci]

LauraMaier added 3 commits July 14, 2022 12:42

Delete Medium model due to double declaration #1171

4fea999

Adapt white list for CI #1171

8bda225

Replace Storage in exergy meter example with correct path #1171

ad99c48

LauraMaier added 2 commits October 12, 2022 22:50

Merge branch 'development' into issue1171_StorageSpringCleaning

b5e83bf

Add conversion script and update AL version #1171

92c7431

LauraMaier and others added 3 commits October 13, 2022 02:22

Merge branch 'development' into issue1171_StorageSpringCleaning

dabb343

Add Storage example on update list "ci_update_ref" #1171

3829755

Automatic push of CI with updated or new regression reference files.P…

48488da

…lease pull the new files before push again. Plottet Results https://ebc.pages.rwth-aachen.de/EBC_all/github_ci/AixLib/issue1171_StorageSpringCleaning/plots/

Merge branch 'development' into issue1171_StorageSpringCleaning

b1e05ae

LauraMaier and others added 2 commits October 14, 2022 19:49

Adapt storage examples to avoid warnings and "ci_update_ref" #1171

812ab0f

Automatic push of CI with updated or new regression reference files.P…

d862f12

…lease pull the new files before push again. Plottet Results https://ebc.pages.rwth-aachen.de/EBC_all/github_ci/AixLib/issue1171_StorageSpringCleaning/plots/

FWuellhorst mentioned this pull request Oct 22, 2022

Issue1223 new storage examples #1307

Open

FWuellhorst previously approved these changes Oct 28, 2022

View reviewed changes

Delete import SI and change to full paths #1171

1f23ab7

LauraMaier dismissed FWuellhorst’s stale review via 1f23ab7 October 28, 2022 20:49

Merge branch 'development' into issue1171_StorageSpringCleaning

e148bd7

LauraMaier marked this pull request as draft October 31, 2022 02:53

LauraMaier marked this pull request as ready for review October 31, 2022 02:53

LauraMaier requested a review from FWuellhorst October 31, 2022 02:53

LauraMaier added 2 commits November 1, 2022 17:46

Merge branch 'development' into issue1171_StorageSpringCleaning

f00bda7

Merge branch 'development' into issue1171_StorageSpringCleaning

5c46e4b

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Issue1171 storage spring cleaning #1226

Issue1171 storage spring cleaning #1226

LauraMaier commented Jan 28, 2022

FWuellhorst left a comment

FWuellhorst left a comment

ebc-aixlib-bot commented Jul 15, 2022

FWuellhorst commented Oct 12, 2022

ebc-aixlib-bot commented Oct 12, 2022

ebc-aixlib-bot commented Oct 12, 2022

ebc-aixlib-bot commented Oct 13, 2022

ebc-aixlib-bot commented Oct 13, 2022

FWuellhorst commented Oct 14, 2022

LauraMaier commented Oct 17, 2022

LauraMaier commented Oct 21, 2022

FWuellhorst left a comment

Issue1171 storage spring cleaning #1226

Are you sure you want to change the base?

Issue1171 storage spring cleaning #1226

Conversation

LauraMaier commented Jan 28, 2022

FWuellhorst left a comment

Choose a reason for hiding this comment

FWuellhorst left a comment

Choose a reason for hiding this comment

ebc-aixlib-bot commented Jul 15, 2022

FWuellhorst commented Oct 12, 2022

ebc-aixlib-bot commented Oct 12, 2022

ebc-aixlib-bot commented Oct 12, 2022

ebc-aixlib-bot commented Oct 13, 2022

ebc-aixlib-bot commented Oct 13, 2022

FWuellhorst commented Oct 14, 2022

LauraMaier commented Oct 17, 2022

LauraMaier commented Oct 21, 2022

FWuellhorst left a comment

Choose a reason for hiding this comment