Allow stack track logging on failing Result.Act() #64
Conversation
| @@ -85,7 +85,7 @@ public Result<TOut> Act<TOut>(Func<TModel, Result<TOut>> action) | |||
| return new(outcome.IsValid | |||
| ? outcome.Value | |||
| : default, | |||
| ((FixedMessages)Messages).AddRange(outcome.Messages)); | |||
| ((FixedMessages)Messages).AddRange(outcome.Messages).Add(ActFailed.New(outcome.IsValid))); | |||
There was a problem hiding this comment.
I think adding a new message might not be visible enough, especially if you have many other error messages. I would prefer to see something more in line with debugger breakpoints.
| /// <inheritdoc /> | ||
| public ValidationSeverity Severity | ||
| => Trace is { } | ||
| ? ValidationSeverity.Error |
There was a problem hiding this comment.
I think it would perhaps be beneficial to introduce a new severity for this (e.g. Debug)
There was a problem hiding this comment.
Given:
/// <summary>The validation severity of a <see cref="IValidationMessage"/>.</summary>
public enum ValidationSeverity
{
/// <summary>Successful message (so no severity).</summary>
None = -1,
/// <summary>Informative message severity.</summary>
Info = 0,
/// <summary>Warning message severity.</summary>
Warning = 1,
/// <summary>Error message severity.</summary>
Error = 2,
}That can be challenging. I already considered Info a better severity, but a new level might be problematic.
There was a problem hiding this comment.
I'm not entirely sure how this snippet is meant to show that adding a new severity is challenging? If you mean that the integer values of the enum are meant to also bear some meaning, then I would propose to make Debug have the value of -2, since the message is theoretically only present during debugging and is therefore similar to None (except that it doesn't get filtered).
There was a problem hiding this comment.
-2 would indeed be the logical value. But there is at least 1 place that has logic stating: Severity > Severity.None. In this case to add messages to a result to create. Furthermore, by making the value public, also other messages with a DEBUG severity can be created, I don't think I like that to happen.
From multiple channels, people have given the feedback that debugging longer chains of
.Act()can be hard to debug. This PR is an attempt to improve the debugger experience.The main idea is to add a custom
IValidationMessagethat contains theStackTraceonce a.Act()execution results in an invalid result.