Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: type-hinting in ScheduledEvent.subscribers #2400

Merged
merged 13 commits into from Mar 22, 2024
Merged

fix: type-hinting in ScheduledEvent.subscribers #2400

merged 13 commits into from Mar 22, 2024

Conversation

yoggys
Copy link
Contributor

@yoggys yoggys commented Mar 19, 2024 •
edited

Summary

Fixed type-hinting for ScheduledEvent.subscribers parameter limit: Optional[:class:int]

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@yoggys yoggys requested a review from a team as a code owner March 19, 2024 22:37
@pullapprove4 pullapprove4 bot requested a review from VincentRPS March 19, 2024 22:37
@yoggys yoggys changed the title fix: hint-typing in ScheduledEvent.subscribers fix: type-hinting in ScheduledEvent.subscribers Mar 19, 2024
@yoggys
Copy link
Contributor Author

yoggys commented Mar 19, 2024

ahaha wrong title

@yoggys
fix: return type of subscribers
c394a14
@yoggys
Merge remote-tracking branch 'origin/scheduled-event-typing' into sch…
727fb60 
…eduled-event-typing
@yoggys
Update CHANGELOG.md
f204440 
Signed-off-by: YoggieS <61660055+yoggys@users.noreply.github.com>
plun1331
plun1331 reviewed Mar 20, 2024
View reviewed changes
discord/iterators.py Outdated Show resolved Hide resolved
@yoggys yoggys requested a review from plun1331 March 20, 2024 23:00
plun1331
plun1331 previously approved these changes Mar 21, 2024
View reviewed changes
@plun1331 plun1331 enabled auto-merge (squash) March 21, 2024 00:14
@plun1331 plun1331 added this to the v2.6 milestone Mar 21, 2024
JustaSqu1d
JustaSqu1d suggested changes Mar 21, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@yoggys
Update CHANGELOG.md
4beaa1c 
Signed-off-by: YoggieS <61660055+yoggys@users.noreply.github.com>
auto-merge was automatically disabled March 21, 2024 19:46

Head branch was pushed to by a user without write access

@yoggys yoggys requested a review from Dorukyum March 21, 2024 19:49
@Lulalaby
Merge branch 'master' into scheduled-event-typing
2cbc961 
Signed-off-by: Lala Sabathil <lala@pycord.dev>
@Dorukyum Dorukyum enabled auto-merge (squash) March 22, 2024 09:08
@Dorukyum Dorukyum merged commit a29bc14 into Pycord-Development:master Mar 22, 2024
29 checks passed
@yoggys yoggys mentioned this pull request Mar 23, 2024
Merged
9 tasks
@yoggys yoggys deleted the scheduled-event-typing branch March 25, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lulalaby Lulalaby Lulalaby approved these changes

@Dorukyum Dorukyum Dorukyum approved these changes

@VincentRPS VincentRPS Awaiting requested review from VincentRPS

@JustaSqu1d JustaSqu1d Awaiting requested review from JustaSqu1d

@plun1331 plun1331 Awaiting requested review from plun1331

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.6
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@yoggys @Lulalaby @plun1331 @Dorukyum @JustaSqu1d