Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: TypeError when ScheduledEvent.subscribers limit is None #2407

Merged
merged 4 commits into from Mar 23, 2024
Merged

fix: TypeError when ScheduledEvent.subscribers limit is None #2407

merged 4 commits into from Mar 23, 2024

Conversation

yoggys
Copy link
Contributor

@yoggys yoggys commented Mar 21, 2024 •
edited

Summary

Fixed a bug for the case where ScheduledEvent.subscribers was executed with the parameter limit=None.
Updated ScheduledEventSubscriber to include user_id parameter.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@yoggys yoggys requested a review from a team as a code owner March 21, 2024 20:38
@pullapprove4 pullapprove4 bot requested a review from WhoIsConch March 21, 2024 20:38
@Lulalaby
Copy link
Member

conflicts

JustaSqu1d
JustaSqu1d suggested changes Mar 21, 2024
View reviewed changes
Copy link
Member

@JustaSqu1d JustaSqu1d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

English US conventions

CHANGELOG.md Outdated Show resolved Hide resolved
@yoggys
Copy link
Contributor Author

yoggys commented Mar 22, 2024

conflicts

resolved

@yoggys yoggys requested a review from JustaSqu1d March 22, 2024 00:18
@Lulalaby Lulalaby enabled auto-merge (squash) March 22, 2024 09:10
auto-merge was automatically disabled March 22, 2024 09:34

Head branch was pushed to by a user without write access

@Lulalaby Lulalaby enabled auto-merge (squash) March 22, 2024 10:52
@Lulalaby Lulalaby requested review from Dorukyum and removed request for WhoIsConch and JustaSqu1d March 22, 2024 10:52
plun1331
plun1331 reviewed Mar 22, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@Lulalaby Lulalaby disabled auto-merge March 23, 2024 14:56
@Lulalaby Lulalaby self-assigned this Mar 23, 2024
@Lulalaby Lulalaby enabled auto-merge (squash) March 23, 2024 15:46
@yoggys yoggys requested a review from plun1331 March 23, 2024 15:51
@Lulalaby Lulalaby merged commit 548ca85 into Pycord-Development:master Mar 23, 2024
29 checks passed
@yoggys yoggys deleted the fix-fillsubs-typeerror branch March 25, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lulalaby Lulalaby Lulalaby approved these changes

@plun1331 plun1331 plun1331 approved these changes

@Dorukyum Dorukyum Awaiting requested review from Dorukyum

@JustaSqu1d JustaSqu1d Awaiting requested review from JustaSqu1d

Assignees

@Lulalaby Lulalaby

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yoggys @Lulalaby @plun1331 @JustaSqu1d