Add guide for better assertions #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Tetramputechture, please add a |
upmedc
approved these changes
Jun 11, 2018
danielrlatham
approved these changes
Jun 11, 2018
Tetramputechture
added
Status: Ready To Ship
and removed
Status: Review Complete
labels
chevinbrown
reviewed
Jun 12, 2018
| assert_predicate @user, :valid? # on error: expected @user to be valid? | ||
| assert_includes response['message'], 'must be a valid email' # on error: expected response['message'] to include 'must be a valid email` |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using assertions, we should prefer to use more specific assertion functions for more meaningful tests, error messages, and easier debugging.
For example, using only
assertgives usExpected false to be truthyon failure, but using something likeassert_includeswill give usExpected {string} to include {substring}.