Update to Font Awesome 4.1 - more complexity in the generator scripts #21
Conversation
…have access to the original naming convention there for generating lookup code
…n unicode sequqnce
…ience constructor to create an icon by name and updated example code to use name base lookup. unfortunately new font icons are not yet shown in the example app
…ew icons seems to break at the old size of 60
|
👍 Any chance this will get released soon? |
|
Sorry for my absence, been busy on my daily job. I finally got myself a small vocation this weekend. I'm going to review this PR, maybe write some test for it, you will see a new release next monday. PS: Just noticed that Font-Awesome introduced the pied-piper icon in the 4.1 release, I ❤️ those geeks. |
|
The PR changed how FAK works in a certain extent, since now we have Swift compatibility to worry about, I will stick to the old way before I could find a new way to make the syntax look great in Objective-C and Swift. I've updated FAK to 2.1.6 to support font-awesome 4.1, this PR will probably be suspended for a while (Sorry for the hard work). |
|
No worries. I'll keep the fork around, in case there are some parts you can use. I'm curious about the swift compability part, as I've found no hint yet, that there are changes needed (other than perhaps exposing the static strings in the header files, which also would benefit the Objective-C implementation). But I've only watched some WWDC sessions and not yet tested the language and its bridging to Objective-C. So take that with a grain of salt. |
|
Yes, FAK is Swift compatible by default, but the syntax isn't quite pleasing, now we have to call let icon = FAKFontAwesome.starIconWithSize(20)to get an icon. It would be more "swifty" to use a designated initializer like this let icon = FAKFontAwesome(glyph: .Star, size: 20)Swift has a more sanity and powerful enum type, I'd like to take advantage of it. |
as discussed in #19