-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FontAwesome +allIcons mapping #19
Comments
👍 |
I've been a little bit busy on my daily job lately and didn't notice the Font-Awesome's new release. It would be nice if you can upgrade the font to 4.1 for us. |
I'll look into upgrading the font later on with the generators (will take probably a little while, as I have no previous experience with Ruby yet) and will probably through in some proposals for utility methods. I've also thought a little bit about dynamically creating methods inside the objective-c runtime. Unfortunately this won't give us that much benefits, as you have to declare the methods in the header files anyway and I think we can generate code and avoid repetition of the data in the code without having to do invocation voodoo. I'll get back to you, when I've toyed a little bit more with the generators. That won't be before this evening - most probably tomorrow. |
The update to version 4.1 of font awesome is done. As I made quite a lot of changes in the generator (and don't know much about ruby), you will probably want to have a look at it and add your thoughts. Some things to consider:
I'll initiate a pull request once we reach a point, where you are satisfied with the changes. |
Looks cool! 👍 |
I close this ticket, since the pull request has created a new one (#21) |
I'm currently playing around with FontAwesomeKit (see here for first impressions) and noticed, that the
allIcons
- Method returns a mapping of unicode values to icon names in camel case. Wouldn't this mapping make much more sense the other way around?This way you could lookup icons by their name as given by the Font Awesome project itself and you would be able to support name aliases:
Martin
p.S.: Do you need help to upgrade to font version 4.1?
The text was updated successfully, but these errors were encountered: