Skip to content

Add dotnet_diagnostic.CA1859.severity = suggestion to editorconfig #25143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 8, 2025
Merged

Add dotnet_diagnostic.CA1859.severity = suggestion to editorconfig #25143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
82cffbf
Add CA1859 to editorconfig
ArmaanMcleod Mar 8, 2025
9ae32af
Add Rule comment above link
ArmaanMcleod Mar 8, 2025
9857979
Add section for diagnostic settings
ArmaanMcleod Mar 8, 2025
7806b6e
Add colon at the end of header
ArmaanMcleod Mar 8, 2025
eb63f06
Add dot to end of comment in build.psm1
ArmaanMcleod Mar 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .editorconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,13 @@ csharp_prefer_simple_default_expression = true:suggestion

dotnet_code_quality_unused_parameters = non_public:suggestion

# Dotnet diagnostic settings:
[*.cs]

# CA1859: Use concrete types when possible for improved performance
# https://learn.microsoft.com/en-gb/dotnet/fundamentals/code-analysis/quality-rules/ca1859
dotnet_diagnostic.CA1859.severity = suggestion

Comment on lines +122 to +128
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iSazonov We could probably move all our existing diagnostic rules from globalconfig here in another PR.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we can.
Looking commit history of the file we can figure out all the changed options.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And please add dummy change in a file to trigger CIs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added another dot to build.psm1.

# CSharp code style settings:
[*.cs]

Expand Down
2 changes: 1 addition & 1 deletion build.psm1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ param(
# CI runs with PowerShell 5.0, so don't use features like ?: && ||
Set-StrictMode -Version 3.0

# On Unix paths is separated by colon
# On Unix paths is separated by colon.
# On Windows paths is separated by semicolon
$script:TestModulePathSeparator = [System.IO.Path]::PathSeparator
$script:Options = $null
Expand Down
Loading