Keep the main page stable when selecting a space - #4040
Merged
Conversation
Generated-By: PostHog Code Task-Id: 0edeed54-a9e6-40c6-9ad3-73b989bd8db1
|
😎 Merged successfully - details. |
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
k11kirky
marked this pull request as ready for review
July 31, 2026 12:00
Contributor
|
Reviews (1): Last reviewed commit: "fix: preserve page when selecting a spac..." | Re-trigger Greptile |
Contributor
Author
|
/truck merge |
Contributor
Author
|
/trunk merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Selecting a space immediately replaced the main window with that space’s feed.
Why: Space selection should scope the sidebar first, while navigation should happen only after the user chooses content within that space.
Changes
How did you test this?
pnpm exec vitest run src/features/canvas/components/ChannelsList.test.tsx(20 tests)pnpm exec biome check src/features/canvas/components/ChannelsList.tsx src/features/canvas/components/ChannelsList.test.tsxAutomatic notifications
Created with PostHog Code