Skip to content

fix(canvas): float the workspace mode selector over the channel feed - #3960

Merged
trunk-io[bot] merged 3 commits into
mainfrom
posthog-code/float-channel-workspace-mode-selector
Jul 30, 2026
Merged

fix(canvas): float the workspace mode selector over the channel feed#3960
trunk-io[bot] merged 3 commits into
mainfrom
posthog-code/float-channel-workspace-mode-selector

Conversation

@adboio

@adboio adboio commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Problem

In a context's message feed, the local/cloud workspace selector sat in its own row inside the composer's opaque, full-width band. With no top padding on that band, scrolling the feed clipped messages at the selector chip rather than at the input box, so the selector read as a strip of chrome bolted onto the bottom of the feed instead of a control belonging to the composer.

Why: raised as visual polish — the selector should look like it's hovering just above the input box, not occupying its own full-width container.

Changes

  • Position the selector row absolutely at bottom-full of the composer (the same pattern the new-task composer already uses), so it floats over the feed and only the input box sits on solid background.
  • Add a small top gutter to the composer band so the input box isn't flush against clipped feed content.

Side effect: arming canvas mode hides the selector without the input box jumping, since the row no longer takes layout space.

How did you test this?

CSS-only change; verified biome check (including useSortedClasses) passes on both touched files. Not exercised in the running app.

Automatic notifications

  • Publish to changelog?
  • Alert Sales and Marketing teams?

Created with PostHog Code

The local/cloud selector above the channel composer occupied its own row in
the composer's opaque, full-width band, so scrolling the feed cut messages off
at the selector instead of at the input box.

Position it absolutely above the input (matching the new-task composer) and give
the composer band a small top gutter, so the chip hovers over the feed and only
the input box sits on solid background.

Generated-By: PostHog Code
Task-Id: e21b284f-a889-4f05-a683-8f2407961fa5
@trunk-io

trunk-io Bot commented Jul 29, 2026

Copy link
Copy Markdown

😎 Merged successfully - details.

@github-actions

github-actions Bot commented Jul 29, 2026

Copy link
Copy Markdown

React Doctor found no issues in the changed files. 🎉

Reviewed by React Doctor for commit 4ce6201.

adboio added 2 commits July 29, 2026 12:23
Quill's outline button fill is `--muted` at 30%, so once the selector floated
over the feed the messages behind it showed through. Put an opaque `bg-card`
backdrop on the row at the button's own radius (`--radius-sm`), which leaves the
trigger's hover and expanded fills intact.

Generated-By: PostHog Code
Task-Id: e21b284f-a889-4f05-a683-8f2407961fa5
The selector hangs 24px over the end of the feed, more than the scroll
content's 16px bottom padding, so at the end of the feed it sat on top of the
last message. Deepen the feed's bottom padding to 40px, which restores the same
16px of clearance the in-flow selector row used to leave.

Generated-By: PostHog Code
Task-Id: e21b284f-a889-4f05-a683-8f2407961fa5
@adboio
adboio marked this pull request as ready for review July 29, 2026 16:26
@adboio adboio added the Stamphog This will request an autostamp by stamphog on small changes label Jul 29, 2026
@adboio
adboio requested a review from a team July 29, 2026 16:27
@greptile-apps

greptile-apps Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Reviews (1): Last reviewed commit: "fix(canvas): keep feed clear of the floa..." | Re-trigger Greptile

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small, contained CSS-only styling change to reposition a UI element; matches the PR description, no risky territory touched.

  • Author wrote 0% of the modified lines and has 11 merged PRs in these paths (familiarity MODERATE).
  • 👍 on the PR from greptile-apps[bot].
Gate mechanics and policy version
Gate Result
prerequisites all clear
deny-list no deny categories matched
size 16L, 3F substantive — within ceiling
tier T1-agent / T1a-trivial (16L, 3F, single-area, fix)
stamphog 2.0.0b3 .stamphog/policy.yml @ 5ee94e2 · reviewed head 4ce6201

@trunk-io
trunk-io Bot merged commit 5ac5892 into main Jul 30, 2026
45 checks passed
@trunk-io
trunk-io Bot deleted the posthog-code/float-channel-workspace-mode-selector branch July 30, 2026 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Stamphog This will request an autostamp by stamphog on small changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant