fix(agents): validate the agent slug before building the ingress URL - #3954
Merged
Conversation
|
😎 Merged successfully - details. |
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
The agent slug becomes a subdomain label in the ingress URL (`<slug>.agents.<region>.posthog.com`), but it arrived from an `?agent=` approval deep link and was interpolated without any validation, so a slug that isn't a plain label could change where the resulting request goes. Validate it as a single DNS label in two places: the deep-link handler drops a malformed slug so the link falls back to the fleet Approvals inbox, and `agentIngressBaseUrl` returns null rather than interpolating one, which keeps callers on their existing "no ingress" path.
tatoalo
force-pushed
the
fix/agent-slug-ingress-validation
branch
from
July 29, 2026 14:46
0ebcce2 to
797fac9
Compare
tatoalo
marked this pull request as ready for review
July 29, 2026 14:47
Contributor
|
Reviews (1): Last reviewed commit: "fix(agents): validate the agent slug bef..." | Re-trigger Greptile |
jonathanlab
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The agent slug from an
?agent=<slug>approval deep link becomes a subdomain label in the ingress URL (<slug>.agents.<region>.posthog.com), and it was interpolated into that template with no validation.Deep links are untrusted input — anyone can hand a user a
<scheme>://approval/...?agent=<anything>URL. A slug that isn't a plain DNS label (one containing.,/,@,#,?,:or\) can therefore alter the structure of the resulting URL rather than just naming an agent, which is not a shape we want a credentialed client request to take.Changes
nullinstead of building an ingress URL for invalid slugs, preserving the existing no-ingress path