feat(loops): improve loops list organization - #3759
Merged
Merged
Conversation
|
😎 Merged successfully - details. |
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
MattPua
marked this pull request as ready for review
July 23, 2026 14:10
Contributor
Prompt To Fix All With AIFix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
packages/ui/src/features/loops/components/LoopsListView.tsx:286-291
**Scope the personal empty state**
When a user has team loops but no personal loops, the default personal tab displays the product-wide “Create your first loop” onboarding while hiding the existing loops behind the team tab. Use personal-specific empty-state copy here so the filtered panel does not imply that no loops exist.
Reviews (1): Last reviewed commit: "fix: restore stacked loops empty state" | Re-trigger Greptile |
Contributor
|
✅ Visual changes approved by @MattPua — baseline updated in 6 changed. |
Generated-By: PostHog Code Task-Id: 9cac87f7-3d2e-4240-8e3f-722952dd6987
Generated-By: PostHog Code Task-Id: 9cac87f7-3d2e-4240-8e3f-722952dd6987
6 updated Run: 9bc8cfca-b5f8-4ad4-ad02-2eca6e724a46 Co-authored-by: MattPua <3376526+MattPua@users.noreply.github.com>
MattPua
force-pushed
the
posthog-code/improve-loops-list
branch
from
July 24, 2026 13:24
b93200b to
2dd57f5
Compare
Generated-By: PostHog Code Task-Id: 726a62ad-ada6-4718-a5a8-8b7a5c466172
There was a problem hiding this comment.
Contained, reversible UI feature (loops tabs, empty states, responsive styling) with no risky-territory surface touched and test coverage added; the one outstanding review comment is a cosmetic UX nit, not a showstopper.
- Author wrote 18% of the modified lines and has 12 merged PRs in these paths (familiarity MODERATE).
- 👍 on the PR from greptile-apps[bot].
- Greptile's inline comment about scoping the personal-tab empty state (when team loops exist but personal is empty) is marked resolved but the personal-empty-state branch in LoopListTabs still renders the generic contextName-less LoopsEmptyState — likely just an unaddressed copy nit, not a functional/security issue.
Gate mechanics and policy version
| Gate | Result | |
|---|---|---|
| prerequisites | ✓ | all clear |
| deny-list | ✓ | no deny categories matched |
| size | ✓ | 310L, 7F substantive, 410L/9F incl. docs/generated/snapshots — within ceiling |
| tier | ✓ | T1-agent / T1d-complex (410L, 9F, two-areas, feat) |
| stamphog 2.0.0b3 | .stamphog/policy.yml @ 7e8e4da · reviewed head 3c69464 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Personal and team loops are shown together, and the loops UI overflows in narrow containers.
Changes
Before:


After:



How did you test this?
pnpm --filter @posthog/ui test(2,000 tests)pnpm --filter @posthog/ui typecheckpnpm exec biome check packages/ui/src/features/loops/components packages/ui/src/features/canvas/components/WebsiteChannelLoops.tsxgit diff --checkAutomatic notifications
Created with PostHog Code