Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev → main 3/25/24 #233

Merged
merged 75 commits into from Mar 29, 2024
Merged

dev → main 3/25/24 #233

merged 75 commits into from Mar 29, 2024

Conversation

joshuagraber and others added 30 commits March 13, 2024 06:02
Include snapshot for error state
add optional component prop
…ed_password_reset

Improved password reset
@josh-chamberlain
Copy link
Contributor Author

@mbodeantor how do you feel about merging into main for most things, and keeping dev up to date / using it to test large or critical things that need to be deployed to test properly → merged into main individually?

@mbodeantor
Copy link
Contributor

@josh-chamberlain That could work, it would then be incumbent on anyone merging their code into dev to first merge main into dev.

@joshuagraber
Copy link
Contributor

PR is here for the password hints on /reset-password/:token

@mbodeantor
Copy link
Contributor

@joshuagraber @josh-chamberlain I think this is ready to go then?

@josh-chamberlain josh-chamberlain marked this pull request as ready for review March 28, 2024 16:10
@josh-chamberlain
Copy link
Contributor Author

@mbodeantor yeah, works for me!

@maxachis
Copy link
Contributor

@josh-chamberlain That could work, it would then be incumbent on anyone merging their code into dev to first merge main into dev.

@josh-chamberlain @mbodeantor Alternatively, we create a Github Action which, on a Dev PR, merges Main into Dev first. I could create an issue on that. Would save time and reduce risk of someone forgetting to do that.

@josh-chamberlain
Copy link
Contributor Author

I think this will happen on its own—when you create a PR, you can see how many commits you are behind main. We could maybe schedule a job to open a PR, but not merge it.

@mbodeantor
Copy link
Contributor

@josh-chamberlain @maxachis I think the github action on PR could be handy. We already have some running on PR open so it would just be a fairly simple addition to the pull file

@mbodeantor mbodeantor merged commit ad65bc4 into main Mar 29, 2024
8 checks passed
@maxachis maxachis deleted the dev branch April 6, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants